Refactor getQueryParameters() to use URL/URLSearchParams about pony-playground HOT 7 CLOSED

@jemc we didnt update it from the original codebase for ages. I didnt do any work on the frontend bits, but would be happy to get those on stable feet. Happy for every improvement here.

from pony-playground.

Those aren't my functions. They belong to everyone. Treat them like they are yours. Whatever improves code quality, Iwe are happy to accept. I can write Rust and Pony, but I don't really dare to touch javascript.
So I hereby hand ownership of the JS code in here to you. It is old and hungry and copied and only slightly adapted from the rust playground it was forked from. Feel free to improve in any way you deem helpful (mostly to you doing further improvements).

from pony-playground.

@mfelsche - are we still pulling in updated code from the Rust playground that we lifted from (in which case it may not make sense to make a bunch of maintainability-focused changes to the javascript code) or are we pretty decoupled from that upstream repo now (in which case it may indeed make sense to make iterative small improvements)?

from pony-playground.

Am I missing something or is samples obsolete and can be removed?

from pony-playground.

It doesn't seem to be referenced. Your js language server of choice might know more through some static analysis.

from pony-playground.

Would you like to have JSDoc comments above your functions?

from pony-playground.

Those aren't my functions. They belong to everyone.

Yeah, sorry, bad wording on my part 😅 I didn't mean singular "you". More like that the repository owners might have a little more say in this

Treat them like they are yours. Whatever improves code quality, Iwe are happy to accept. […] So I hereby hand ownership of the JS code in here to you. […] Feel free to improve in any way you deem helpful (mostly to you doing further improvements).

Perfect 👍🏻 Will do.

from pony-playground.