Suggestion: simplify and generalize utils.angle about bezierjs HOT 4 CLOSED

Ok, so I tested your updated implementation vs. the one I was suggesting: https://esbench.com/bench/5857b9b0d5686f990078bb32
My tests show that both implementations run equally fast in Firefox, and that the double atan2 implementation runs 4 times slower in Chrome (Firefox seems 10x faster on this micro-bench). So I'd say let's stick with your implementation.

from bezierjs.

angle got simplified in v2.2.2, so the only benefit would be "angle between three points". As a bezier library, what goes in utils is mostly based on "does the library itself need it", rather than "is it useful on its own", because the latter shouldn't be in the bezier-specific utils file =)

For deciding whether to keep the current angle, or use yours, I'd be interested in seeing the perf difference. Would you be interested in seeing if you can get numbers associated with both functions?

from bezierjs.

Sure, I'll do that as soon as jsperf.com is back online :-)
jsperf/jsperf.com#289

from bezierjs.

that is not happening any time soon, jsperf is down because it could not prevent itself from getting hammered, without a solution in sight. But you don't need jsperf, writing your own timer in node/browser is pretty easy

from bezierjs.