Comments (5)
Given that the max int value that JS can faithfully represent is 9007199254740991 (0x1FFFFFFFFFFFFF), that value is most certainly incorrect.
from bezierjs.
Ok, so should the code use 0x1FFFFFFFFFFFFF instead of 0xFFFFFFFFFFFFFFFF and 99999999?
I believe I've also seen bbox algorithms in js using +Infinity and -Infinity. This should work well.
from bezierjs.
I don't really like Infinity
for the fact that it's not correct (Infinity === Infinity
is true, which is absolute nonsense, mathmatically) so I'd much rather use Number.MAX_SAFE_INTEGER
and Number.MIN_SAFE_INTEGER
, probably cached as scoped vars so there's no need to do a lookup through the Number namespace beyond assignment.
from bezierjs.
Alright, let me know if you want me to do that PR or if you find it quicker to do it yourself.
from bezierjs.
PRs are always quicker than me adding it in unless I'm in a period of active maintenance, which for bezier.js I'm not =)
If you want to help, much appreciated!
from bezierjs.
Related Issues (20)
- Get the length of the curve at some `t` HOT 1
- _lut caching doesn't work: steps is off by one HOT 5
- Release v6.1.2 broken HOT 3
- Why get(t = 0.5) point is not the middle point of the curve? HOT 5
- Find optmal D1 - Bezier.cubicFromPoints HOT 1
- PolyBezier is not exported correct for ES Module. HOT 3
- Rational Bezier Curve Support HOT 1
- Example usage of `dist/bezier.js` HOT 4
- How to make a "strict" version of bezier.project(point)? HOT 2
- Should bezier.lineIntersects(line) work for line-line intersections? HOT 3
- intersects bug Bezier to Bezier HOT 3
- Suspicious line in `utils.compute()` HOT 2
- The intersection of the two bezier is empty HOT 9
- The intersection of two identical curves HOT 2
- Intersect line method does not always return existing intersections HOT 4
- Ability to get and estimate the centerline of a list of 3D points HOT 3
- PR for extending API to interpolate values along curve and find point on curve at distance?
- Artifact when offsetting an SVG path
- Split curves do not follow old curve. HOT 2
- Missing LICENSE file HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bezierjs.