Comments (4)
Are you sure you have NV12 and not NV21?
NV12 has a UV plane with U followed by V. NV12ToI420Rotate outputs the U to
the u, u_stride and V to the v, v_stride.
The same function can be used for NV21 by passing u and v swapped.
Original comment by [email protected]
on 7 Mar 2012 at 6:36
from libyuv.
oh wait... my bad. Fixed in r208
Original comment by [email protected]
on 7 Mar 2012 at 6:39
- Changed state: Started
from libyuv.
Original comment by [email protected]
on 7 Mar 2012 at 7:20
- Changed state: Fixed
from libyuv.
Thanks for the fast commit :) !
I'll continue to investigate the other point I mentioned on the libyuv google
group about rotation.
But that's another issue I'll open as soon as I'll get a clear idea of what's
going wrong (and maybe a patch too).
My first analysis is that the culprit is ~maybe~ webRTC that sends to libyuv
request with a rotation of 270 or 90 while they don't invert width and height
for dest frame. (even if that's actually what they want to do, rotate a 352 ×
288 into a new 352 × 288 with content rotate of 270° -- but that's maybe not
supported by libyuv).
Anyway, libyuv probably should make sure that it doesn't try to write out of
the dst frame in this kind of case.
But it's probably more about sanity check than about real "bug" (unless it's
something that could be considered as expected feature of libyuv).
But, I'll keep you in touch with a new issue :). Or if there is another mean
you prefer me to use for this kind of point?
Original comment by [email protected]
on 8 Mar 2012 at 10:32
from libyuv.
Related Issues (20)
- Odd width (any functions) use SIMD HOT 3
- J444
- Switch Rietveld to codereview.chromium.org HOT 1
- clangcl build fail on row_win.cc HOT 8
- gclient sync fail - can't open file 'trunk/sync_chromium.py': [Errno 2] No such file or directory HOT 3
- linux.mk missing scale_any.cc HOT 1
- fixx build libyuv under x64 HOT 2
- ARGBToYUY2 failure on odd width HOT 5
- ios build break on gyp/ninja build HOT 6
- ARGBToUYVY msan failure HOT 3
- ia32 option for iOS does not produce i386 lib HOT 6
- convert.cc:946:5: error: use of undeclared identifier 'RGB24ToARGBRow' HOT 2
- drmemory build breakage HOT 1
- TestI420 fails on odd width with SIMD HOT 1
- AVX2 unittests failure on ARGB4444ToARGB etc. HOT 2
- Core dump calling I420Rotate with irregular size HOT 4
- NV12 rotate with odd width is slow
- Remove macro COVERAGE_ENABLED HOT 1
- UYVYToNV12 HOT 3
- Even when building for armv7, the output library is with arm64 architecture. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libyuv.