Comments (2)
This modification makes crisper unusable with webcomponentjs+polymer. Polymer produces an error:
this._factory is not a function
from crisper.
I guess the problem relates the javascript source map. Before this patch, source map was broken and ignored. However, now vulcanized + crisper code tries to call related (unnecessary and non-exist) external javascript files even if they are already in vulcanized source.
from crisper.
Related Issues (20)
- PERF: Move <script> to top of doc so it downloads sooner HOT 3
- Fails if writing to a directory that doesn't already exist
- Make --script-in-head the default HOT 1
- scripts should be wrapped in IIFEs on concatenation
- Can't set `--script-in-head` to false with command line usage? HOT 1
- Running crisper on HTML imports (e.g., Polymer files) produces a full HTML tree HOT 9
- scripts with type="text/ecmascript-6" are not extracted HOT 7
- This shell not be extracted
- CSS Support HOT 6
- Add repo description
- Don't do scriptInHead by default HOT 2
- Inline scripts in <head> are run at incorrect time
- Support scripts with absolute paths HOT 1
- Crisper causing FOUC
- New Feature Request- 'jsFilePath' HOT 2
- Crisper ignores crossorigin attribute on script tag HOT 3
- Semicolon not added when script ending with a comment causes issues when concatenating
- noSemiColonInsertion regexp incorrect matches // in string
- Uncaught ReferenceError: babelHelpers is not defined
- Vulnerable upstream dependency [email protected]
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from crisper.