Giter Club home page Giter Club logo

Comments (8)

mariakleiner avatar mariakleiner commented on June 25, 2024

this is due to the playground demo only calling the Planner to generate suggestions once.

ui.callback = () => {};

the suggestion-element callback needs to be set to smth that triggers Planner.suggest, similar to the demo-base.js nextStage() method.

from arcs.

sjmiles avatar sjmiles commented on June 25, 2024

In Arcs CDN v0.03 I implemented regenerating suggestions. Please try it out.

from arcs.

mariakleiner avatar mariakleiner commented on June 25, 2024

Thanks, I tested it with the hello-world and chat glitch apps, and it works fine.

from arcs.

sjmiles avatar sjmiles commented on June 25, 2024

In the hello-world glitch (https://glitch.com/edit/#!/arcs-hello-world) after choosing 'Hello' I expect 'Greetings to you' to become a suggestion, as per the discussion in this ticket.

I guess it's what I expected to work as per "tested it with the hello-world glitch app".

I must have the wrong expectation, can you explain?

from arcs.

mariakleiner avatar mariakleiner commented on June 25, 2024

in https://arcs-hello-world.glitch.me/
at first I get 2 suggestions:
"Hello and Greetings to you"
"Hello"

after I choose "Hello", I get 4 suggestions, one of which is "Greetings to you".
Is it not what you're getting?

from arcs.

sjmiles avatar sjmiles commented on June 25, 2024

Sigh. Originally the toast was supposed to open again when there are fresh suggestions, this is the bug in my expectation: because the toast didn't open I assumed there were no suggestions.

A thousand pardons.

from arcs.

mariakleiner avatar mariakleiner commented on June 25, 2024

I actually thought it was a feature, because the demo always behaved like this (I think) - it makes perfect sense to me, when user already has their content on the screen, it might be better for suggestions not to pop up.

from arcs.

sjmiles avatar sjmiles commented on June 25, 2024

At one point I went to special pains to allow the apps to control this behavior (I think I wanted something different in the VR demo). At any rate, this is ancient history.

After I realized my gaffe, I came to the same conclusion you did (that it's better not to pop-up new stuff until the user asks for it).

Thanks for the help!

from arcs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.