Giter Club home page Giter Club logo

Comments (5)

dstoc avatar dstoc commented on July 24, 2024

Although @shans thinks it might already work this way.

from arcs.

shans avatar shans commented on July 24, 2024

It does (or at least used to) in the tests. If you look at test/demo-flow-test.js you can see that a MockSlotManager isn't installed until after speculative execution. At one point, there was no slot manager installed before this.

from arcs.

dstoc avatar dstoc commented on July 24, 2024

I was assuming that https://github.com/PolymerLabs/arcs/blob/master/runtime/outer-PEC.js#L54 would need to be modified to not assume that there is a this.slotManager?

from arcs.

mariakleiner avatar mariakleiner commented on July 24, 2024

Probably it did work earlier, but my previous change broke it, as i pass a SlotManager to the Arc https://github.com/PolymerLabs/arcs/blob/master/runtime/test/demo-flow-test.js#L30

i'm not sure though how it could have worked because outer-PEC always assumes it has slotManager.

Let me try to solve this.

from arcs.

shans avatar shans commented on July 24, 2024

I think actually it probably didn't work, there was just the server-side slot manager until I overrode it.

from arcs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.