Giter Club home page Giter Club logo

Comments (3)

L-u-k-e avatar L-u-k-e commented on August 16, 2024

I have the same issue on IE 11. I'm on Windows 7.

Checking the console reveals that the buttons are incorrectly receiving the .keyboard-focus class by default.

My guess is that a call to toggle() somewhere turns it off when it actually gets focused.

from paper-button.

L-u-k-e avatar L-u-k-e commented on August 16, 2024

I did some logging in iron-button-behavior.html and the focus state is being correctly defaulted to false.

The issue is in paper-button-behavior.html:

observers: [
  '_calculateElevation(focused, disabled, active, pressed, receivedFocusFromKeyboard)',
  '_computeKeyboardClass(receivedFocusFromKeyboard)'
],
...
 _computeKeyboardClass: function(receivedFocusFromKeyboard) {
  this.classList.toggle('keyboard-focus', receivedFocusFromKeyboard); // <- Right Here
},

The observer uses on this.classList.toggle() BUT the second boolean parameter isn't supported in IE / Opera 12-

If you swap out this.classList.toggle() with the utility function Polymer provides for the same purpose: this.toggleClass(), everything works fine.

I'm going to submit a pull request over on https://github.com/PolymerElements/paper-behaviors

from paper-button.

L-u-k-e avatar L-u-k-e commented on August 16, 2024

My pull request was merged with paper-behaviors.

So, this can be closed now.

from paper-button.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.