Giter Club home page Giter Club logo

Comments (4)

neon64 avatar neon64 commented on June 30, 2024

I have managed to track this down to https://github.com/PolymerElements/paper-behaviors/blob/master/paper-ripple-behavior.html#L84. When the actual shadow DOM is used, the Node.contains test fails because <paper-button ....> is not inside #shadow-root.

If I change that line:

if (domContainer.contains(/** @type {Node} */(target))) {

To this:

if ((domContainer.host != undefined && domContainer.host == target) || domContainer.contains(/** @type {Node} */(target))) {

Then it appears to work on the first click. However I feel that that is a rather 'hacky' solution.

from paper-button.

neon64 avatar neon64 commented on June 30, 2024

Mmm, this doesn't work if the target is a an element (eg: <iron-icon>) inside the <paper-button> not the button itself

from paper-button.

cdata avatar cdata commented on June 30, 2024

Thanks for the thorough assessment of the problem. I will take a look.

from paper-button.

keanulee avatar keanulee commented on June 30, 2024

Can't seem to reproduce this issue anymore - going to close this issue. Feel free to reopen if you still see it.

from paper-button.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.