Giter Club home page Giter Club logo

Comments (6)

ZekeZDev avatar ZekeZDev commented on May 29, 2024

Hmm I dont think its a big security concern there is a lot of documentation on using the microsoft api and etc any new account on polymc is handled through microsoft not polymc. Mabye an issue for old mojang accounts but they will be phased out and all the source is open. There is no benefit in having to launch through the official launcher if everyone is on microsoft accounts.

I am not a programmer of polymc this infomation I have gathered from discussion and looking at the microsoft authentication and third party launchers.

from polymc.

binex-dsk avatar binex-dsk commented on May 29, 2024

It's open source for a reason. No reason to add this in my opinion unless others support this

from polymc.

ZekeZDev avatar ZekeZDev commented on May 29, 2024

Mabye we could auto detect their login from the signed in minecraft launcher but thats another thing entirely thats likely a huge security risk however I have seen propreitary launchers do it before.

from polymc.

A-UNDERSCORE-D avatar A-UNDERSCORE-D commented on May 29, 2024

It would be rather brittle to attempt to swipe tokens from a launcher that may change its format. Not to mention thats pretty silly, and possibly not really nice to the vanilla launcher devs.

Personally I dislike the Launcher to launch a Launcher thing, but you can reasonably easily sidestep this with some links and the vanilla launcher anyway, so I dont think adding complexity would be worth the few users that may use it.

from polymc.

ZekeZDev avatar ZekeZDev commented on May 29, 2024

I agree

from polymc.

binex-dsk avatar binex-dsk commented on May 29, 2024

Considering these points I am no longer open to adding this feature. You can always make a fork and implement it yourself if you so desire.

from polymc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.