HTML broken since 2.10.0 about easygettext HOT 5 CLOSED

@torfeld6 Sorry, likely my fault. I tried to find the cause of the bug and it wasn't so much that parseJavascript was the fallback (it was the same before), but that preprocessScript always returns content and language now. Before we passed an empty string to preprocessScript.

Since you have already digged into the code, can you check if changing line 260 in extract.js to

      ({content, lang}) => {
        if (lang) {
          (lang === 'ts' || (!lang  && ext === 'ts'))
            ?  this.parseTypeScript(filename, content)
            :  this.parseJavascript(filename, content)
        }
      }

solves your problem? I would do a PR, but I only added some html templates to my project to reproduce your problem (it solves it and adds the strings to the .po files) and am not sure if there aren't some other cases I might have missed.

from easygettext.

Hi @Shin-- thank you for the quick reply. I tried to address the issue in the PR #86

from easygettext.

@torfeld6 Is this resolved in the latest release?

from easygettext.

@torfeld6 do you think you resolved the issue ? Or do you think you can fix this one as well as #93 in your incoming fix ? 🙏

from easygettext.

@torfeld6 do you think you resolved the issue ? Or do you think you can fix this one as well as #93 in your incoming fix ? 🙏

The HTML issue has been resolved with the release of 2.14. And here's the pull request #94 for #93

from easygettext.