Please don't check the basic_consume callback for iscoroutinefunction about aioamqp HOT 5 CLOSED

This problem is hard to solve, since a coroutine is also a callable :(

from aioamqp.

With Python 3.4 it's possible to set function._is_coroutine=True to circumvent the test, but that's undocumented and not particularly future-proof …

from aioamqp.

Okay. the developper will have a nice error if he does not provide a coroutine :P

from aioamqp.

@smurfix any though ? Sorry for the API compatibility but removing the check without modifying the method signature didn't have any sense (to me).

from aioamqp.

pika uses the same style (i.e. self, callback queue="", …) so this is OK with me.

It's not incompatible if the caller habitually uses keyword-only calling conventions. ;-)

from aioamqp.