Giter Club home page Giter Club logo

Comments (6)

mikeneyens avatar mikeneyens commented on July 28, 2024 1

Hi Martin

I updated to v0.7.0 and used rebuild, the issue is fixed now. Thanks for the help!

from nfc-pcsc.

pokusew avatar pokusew commented on July 28, 2024

Hi @mikeneyens,

thanks for posting your issue here.

It seems that you need to rebuild the native modules. nfc-pcsc uses Node Native Modules under the hood to access system's PC/SC API. Native modules are built against a specific Node.js version present in the runtime (e.g. against the current Electron.js version which contains a specific Node.js runtime).

After you upgrade Electron, you usually need to rebuild the modules. (Native modules are automatically built when installing the dependencies.)

Please see Using Node native modules in the official Electron guide.
I recommend using electron-rebuild.

You can also read the Can I use this library in my Electron app? FAQ in the nfc-pcsc's, where you'll find additional useful information.

FYI: On top of that, native modules depend on the underlaying OS (Windows vs Linux vs macOS), which means they need to be built specifically for each OS and architecture (32bit vs 64bit). This is relevant when targeting more platforms, read more in the FAQs.

Hope it helps. πŸ™‚


PS Don't forget to star ⭐️ my library, if you find it useful. πŸ˜ƒ Thanks.

from nfc-pcsc.

mikeneyens avatar mikeneyens commented on July 28, 2024

Thanks for the fast response!

Unfortunately I tried rebuilding using electron-rebuild, but I'm getting multiple errors. I opened an issue over there (electron/rebuild#263 ).

from nfc-pcsc.

mikeneyens avatar mikeneyens commented on July 28, 2024

Okay, so I made a stupid mistake: electron was not installed as a devDependency. Electron-rebuild now works. However, when I try to open the app nothing works like it should, even Developer Tools.
When I comment out the portion of NFC code, everything works fine.

I tried re-installing nfc-pcsc, now I'm getting following errors:

c:\users\mike.node-gyp\10.13.0\include\node\v8.h(2658): note: see declaration of 'v8::String::WriteUtf8' (compiling source file ..\src\pcsclite.cpp)
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\common.h(34): warning C4477: '_snprintf' : format string '%s' requires an argument of type 'char *', but variadic argument 2 has type 'LPVOID' (compiling source file ..\src\ca
rdreader.cpp) [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\common.h(34): warning C4477: '_snprintf' : format string '%s' requires an argument of type 'char *', but variadic argument 2 has type 'LPVOID' (compiling source file ..\src\pc
sclite.cpp) [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(91): warning C4996: 'v8::String::Utf8Value::Utf8Value': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj
]
c:\users\mike.node-gyp\10.13.0\include\node\v8.h(2891): note: see declaration of 'v8::String::Utf8Value::Utf8Value'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(94): warning C4996: 'v8::Value::ToString': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike.node-gyp\10.13.0\include\node\v8.h(10040): note: see declaration of 'v8::Value::ToString'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\pcsclite.cpp(183): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(137): warning C4996: 'v8::Value::Uint32Value': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'
c:\users\mike.node-gyp\10.13.0\include\node\v8.h(2477): note: see declaration of 'v8::Value::Uint32Value'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\pcsclite.cpp(186): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(138): warning C4996: 'v8::Value::Uint32Value': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'
c:\users\mike.node-gyp\10.13.0\include\node\v8.h(2477): note: see declaration of 'v8::Value::Uint32Value'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(172): warning C4996: 'v8::Value::Uint32Value': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike.node-gyp\10.13.0\include\node\v8.h(2477): note: see declaration of 'v8::Value::Uint32Value'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(218): warning C4996: 'v8::Value::ToObject': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike.node-gyp\10.13.0\include\node\v8.h(10046): note: see declaration of 'v8::Value::ToObject'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(219): warning C4996: 'v8::Value::Uint32Value': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike.node-gyp\10.13.0\include\node\v8.h(2477): note: see declaration of 'v8::Value::Uint32Value'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(220): warning C4996: 'v8::Value::Uint32Value': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike.node-gyp\10.13.0\include\node\v8.h(2477): note: see declaration of 'v8::Value::Uint32Value'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(273): warning C4996: 'v8::Value::ToObject': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike.node-gyp\10.13.0\include\node\v8.h(10046): note: see declaration of 'v8::Value::ToObject'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(274): warning C4996: 'v8::Value::Uint32Value': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike.node-gyp\10.13.0\include\node\v8.h(2477): note: see declaration of 'v8::Value::Uint32Value'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(275): warning C4996: 'v8::Value::ToObject': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike.node-gyp\10.13.0\include\node\v8.h(10046): note: see declaration of 'v8::Value::ToObject'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(356): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(363): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(374): warning C4996: 'Nan::MakeCallback': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1000): note: see declaration of 'Nan::MakeCallback'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(477): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(486): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(532): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(540): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(593): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(601): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(657): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'
c:\users\mike\desktop\pos\node_modules@pokusew\pcsclite\src\cardreader.cpp(665): warning C4996: 'Nan::Callback::Call': was declared deprecated [C:\Users\Mike\desktop\pos\node_modules@pokusew\pcsclite\build\pcsclite.vcxproj]
c:\users\mike\desktop\pos\node_modules\nan\nan.h(1655): note: see declaration of 'Nan::Callback::Call'

I also can't find a prior issue regarding these errors.

from nfc-pcsc.

pokusew avatar pokusew commented on July 28, 2024

Hi @mikeneyens,

I am very sorry for the late reply. I've been very busy recently.

It's great that you made electron-rebuild work! πŸ‘ Please close the issue electron/rebuild#263 with an appropriate comment.

It turned out that nfc-pcsc did not support Node.js 10.x (the one Eelectron uses) and 11.x.

I upgraded all the dependencies and also made a lot of fixes. Support for all recent Node.js versions along with many improvements is available in v0.7.0. πŸš€

Please upgrade nfc-pcsc in your dependencies and let me know if it works for you. πŸ™‚

Hope it helps. πŸ™‚


PS Don't forget to star ⭐️my library, if you find it useful. πŸ˜ƒThanks.

from nfc-pcsc.

pokusew avatar pokusew commented on July 28, 2024

Hi @mikeneyens, any updates on the issue?
Have you tried to upgrade nfc-pcsc to v0.7.0 and rebuild it using electron-rebuild? Any success?
Please let me know so I can eventually close the issue. Thanks: πŸ™‚

from nfc-pcsc.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.