Giter Club home page Giter Club logo

Comments (2)

Ninjasoturi avatar Ninjasoturi commented on July 22, 2024

In commit e606f52 I improved the raidpicture.php to no longer crash when the gym image fails to load, and it now uses the fallback image instead.

Unfortunately the portal import functionality doesn't save the gym image URLs that we could use to redownload all the images. Adding such functionality would require querying Ingress API with the portal ID somehow, I don't know if that is possible.

from pokemonraidbot.

Chefkeks avatar Chefkeks commented on July 22, 2024

But saving the gym image URL shouldn't be an issue in general and pretty easy to solve.

We just need to extend the gyms table with a new column (e.g. web_url or something like that as we a already have img_url) and always save the url then there. Won't update existing gyms of course.

Anyway, we require a new column in gyms table and need to store $portal_image (https://github.com/pokepark/PokemonRaidBot/blob/main/mods/importal.php#L40) independently from $config->RAID_PICTURE_STORE_GYM_IMAGES_LOCALLY in the new column. Anything else can stay as it is.

Once that is done we need the function to redownload all the missing gym images and also save/update the url in the new (web_url) column. That said, I don't know how easy it might is to do that.

from pokemonraidbot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.