Giter Club home page Giter Club logo

Comments (3)

pokeb avatar pokeb commented on June 9, 2024

Hi Martijn

That was my first thought, however, I felt that setting it in startRequest would be the safest way to ensure that originalURL contains the url actually used for the first request. url could be set after the request is created, either in the method that created the request, or in a subclass. ASIS3ListRequest is an example of a subclass that does this.

Best

Ben

from asi-http-request.

martijnthe avatar martijnthe commented on June 9, 2024

Hmm.. true.
What about setting originalURL in a custom setURL: ?

from asi-http-request.

oscahie avatar oscahie commented on June 9, 2024

I was about to create a ticket for this very same issue but I guess this one can be re-floated :)

IMO the 'originalURL' property should contain what its name implies at all times, not only after the request has started. If for example you have several requests queued there doesn't seem to be a reliable way to identify them by their URL, because 'url' might have changed after a redirect and 'originalURL' might be nil if the request has not started yet.

So I'd definitely vote for having the originalURL set in several places if necessary, but make sure that it is set at any time.

from asi-http-request.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.