Comments (7)
I think I'm confused. Does this happen with all sprites or just these two? It looks like those two just got switched and need to be fixed. 10169
is supposed to be articuno-galar
, and 10172
is supposed to be slowking-galar
.
Or are you looking to extend the sprites
to have an official-artwork/shiny
field?
from sprites.
I presented these 2 cases to illustrate the problem, it seems that the numbering was done based on the images that were available or they're swapped, no clue.
I was previously assuming that the common sprite number will also be the shiny sprite number, and I found that this is not always true.
I don't think there is an shiny-articuno-galar on official-artwork, but there is no way for me to know that from the information that is served in the API, I am getting the images of the shiny version by writing the URL, exactly because it is not served by the API.
Yes, I would like to have information about official-artwork/shiny/ in the API
from sprites.
Yeah, if they're returning different pokemon for the id, then they are the wrong image and should be fixed. /pokemon/10169
should always be articuno-galar
and 10172
should always be slowking-galar
, regardless of shiny or not.
These official-artwork shiny images are a new addition and haven't been added to the api yet, which is why they don't show up on a /pokemon/{id}
call. They have to be added to the build.py
file. You're welcome to add a PR to add the field if you'd like, I'm not sure when anyone will get around to doing it. ๐
from sprites.
How contributions are handled? When his PR will go live?
from sprites.
We have to wait for the api-data PR to be merged in.
from sprites.
sorry!! I merged it!
from sprites.
in ~1h will be live, will you be able to test it?
from sprites.
Related Issues (20)
- Add front_default sprites for gen9 HOT 9
- Adding animated sprites/gifs for sprites HOT 6
- Add back_defaults, shiny of missing hiusian and gmax pkmn HOT 5
- Feature Request: Silhouettes of sprites HOT 1
- Paldean Tauros shiny official artwork switch HOT 1
- Transparency issues on gen 5 animated variants HOT 6
- Default sprites for Walking Wake and Iron Leaves HOT 2
- Any guide to add sprites into Docker container ? HOT 3
- File is corrupt on download HOT 1
- #421 - Cherrim - Sunshine Form
- Jellicent - Female Form HOT 6
- Chesnaught back and back shiny sprites missing HOT 2
- Why is there a Rillaboom sprite for gen 5? HOT 1
- Complete Dreamworld SVG collection HOT 25
- Missing items sprites for 8 and 9 Gen HOT 2
- Add type name icons HOT 8
- Images from raw.githubusercontent links do not load HOT 2
- can't able to access images in sprites HOT 3
- Add official artwork for gen 9 Pokรฉmon HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
๐ Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. ๐๐๐
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google โค๏ธ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from sprites.