Giter Club home page Giter Club logo

Comments (7)

C-Garza avatar C-Garza commented on May 19, 2024

I think I'm confused. Does this happen with all sprites or just these two? It looks like those two just got switched and need to be fixed. 10169 is supposed to be articuno-galar, and 10172 is supposed to be slowking-galar.
Or are you looking to extend the sprites to have an official-artwork/shiny field?

from sprites.

triesharder avatar triesharder commented on May 19, 2024

I presented these 2 cases to illustrate the problem, it seems that the numbering was done based on the images that were available or they're swapped, no clue.

I was previously assuming that the common sprite number will also be the shiny sprite number, and I found that this is not always true.

I don't think there is an shiny-articuno-galar on official-artwork, but there is no way for me to know that from the information that is served in the API, I am getting the images of the shiny version by writing the URL, exactly because it is not served by the API.

Yes, I would like to have information about official-artwork/shiny/ in the API

from sprites.

C-Garza avatar C-Garza commented on May 19, 2024

Yeah, if they're returning different pokemon for the id, then they are the wrong image and should be fixed. /pokemon/10169 should always be articuno-galar and 10172 should always be slowking-galar, regardless of shiny or not.
These official-artwork shiny images are a new addition and haven't been added to the api yet, which is why they don't show up on a /pokemon/{id} call. They have to be added to the build.py file. You're welcome to add a PR to add the field if you'd like, I'm not sure when anyone will get around to doing it. ๐Ÿ˜„

from sprites.

triesharder avatar triesharder commented on May 19, 2024

How contributions are handled? When his PR will go live?

from sprites.

C-Garza avatar C-Garza commented on May 19, 2024

We have to wait for the api-data PR to be merged in.

from sprites.

Naramsim avatar Naramsim commented on May 19, 2024

sorry!! I merged it!

from sprites.

Naramsim avatar Naramsim commented on May 19, 2024

in ~1h will be live, will you be able to test it?

from sprites.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.