Giter Club home page Giter Club logo

Comments (14)

Luminarcy avatar Luminarcy commented on June 10, 2024 2

Thank you so much! It will be great if you contribute, but do it only if you feel comfortable

@gustavottc I've added several pages to project's wiki. Also i'd like to make pull request, but i think i don't have rights to make branches.

from godot-admob-android.

Luminarcy avatar Luminarcy commented on June 10, 2024 1

I carefully reinstalled and reconfigured AdMob module, now everything working perfectly! 😊

from godot-admob-android.

Luminarcy avatar Luminarcy commented on June 10, 2024 1

@gustavottc Right now i'm trying to make AdMob for iOS work. After that i may contribute to project's wiki if that okay for you 🙂

from godot-admob-android.

gumaciel avatar gumaciel commented on June 10, 2024 1

Thank you so much! It will be great if you contribute, but do it only if you feel comfortable

from godot-admob-android.

gumaciel avatar gumaciel commented on June 10, 2024 1

@Luminarcy unfortunelly to do that i need to put you the right to "Write" on repository, but this is non-safe because you can also do push to master branch.

If you want to make pull request, you can create a fork of this repository and then create a pull request of your branch's repository to the master branch of this repository, what you think?

And thank you a lot for contributing to the wiki!

from godot-admob-android.

gumaciel avatar gumaciel commented on June 10, 2024 1

Thank you so much!

from godot-admob-android.

gumaciel avatar gumaciel commented on June 10, 2024

Hey! Thank you for create this issue, i will check it

Do you have other phone to test? Can you test with Android Simulator?

from godot-admob-android.

gumaciel avatar gumaciel commented on June 10, 2024

Can you test this app without AdMob to see if the error still happen?

from godot-admob-android.

Luminarcy avatar Luminarcy commented on June 10, 2024

Sorry about delay. Right now i have some problems with singletons.

Somehow this code doesnt print lol
image
image

Any ideas why?

from godot-admob-android.

Luminarcy avatar Luminarcy commented on June 10, 2024

Also there are Engine.has_singleton("AdMob") in this line in your code. Is this right?

from godot-admob-android.

gumaciel avatar gumaciel commented on June 10, 2024

The correct is Engine.has_singleton("AdMob"), i don't know where you get the "MobileAds" but its incorrect

from godot-admob-android.

gumaciel avatar gumaciel commented on June 10, 2024

@Luminarcy Nice!

What you think about the documentation? There's something needed to be improved?

from godot-admob-android.

Luminarcy avatar Luminarcy commented on June 10, 2024

@gustavottc I made the pull request 🙂

from godot-admob-android.

Luminarcy avatar Luminarcy commented on June 10, 2024

You are welcome 🙂

from godot-admob-android.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.