Comments (7)
pofider
commented on July 20, 2024
Hi,
you are right. This requires extending this package. Don't you want to try to implement this and send PR?
- Extend the conversion function options parameter with
cookiesobject - Iterate over the object properties in the phantomjs script and call
addCookie - The unit test could simply just add cookie, write it to console.log and assert the correct value is in the output.
- Update readme
The PR would be basically the same as this one - https://github.com/pofider/phantom-html-to-pdf/pull/46/files
You would probably only use object instead of array to pass cookies.
What you think?
from phantom-html-to-pdf.
chips5k
commented on July 20, 2024
Hi jan, ill give this a go and submit a pr if im succesful. Thanks for the
pointers!
…On Mon, 20 Mar 2017 at 9:35 pm, Jan Blaha ***@***.***> wrote:
Hi,
you are right. This requires extending this package. Don't you want to try
to implement this and send PR?
1. Extend the conversion function options parameter with cookies object
2. Iterate over the object properties in the phantomjs script and call
addCookie
3. The unit test could simply just add cookie, write it to console.log
and assert the correct value is in the output.
4. Update readme
The PR would be basically the same as this one -
https://github.com/pofider/phantom-html-to-pdf/pull/46/files
You would probably only use object instead of array to pass cookies.
What you think?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZlydJuXhDwIfDgljj9CJJK-1HbYZOlks5rnlaOgaJpZM4MiANg>
.
from phantom-html-to-pdf.
chips5k
commented on July 20, 2024
Hi Jan - unfortunately we didn't end up using phantomjs at my workplace -
was consuming too much of my time for a really simple feature. So not sure
when/if i'll get a chance to add this in. I'll try but just wanted to warn
you.
Also FYI, i did give it a quick go this morning, but realized the code i
had from the npm install was different from what is in your git repo -
certain files were missing and their use had changed, e.g conversionScript
instead of serverScript - confused me a bit.
On Tue, Mar 21, 2017 at 7:47 AM, callem pittard <[email protected]>
wrote:
… Hi jan, ill give this a go and submit a pr if im succesful. Thanks for the
pointers!
On Mon, 20 Mar 2017 at 9:35 pm, Jan Blaha ***@***.***>
wrote:
> Hi,
>
> you are right. This requires extending this package. Don't you want to
> try to implement this and send PR?
>
> 1. Extend the conversion function options parameter with cookies
> object
> 2. Iterate over the object properties in the phantomjs script and
> call addCookie
> 3. The unit test could simply just add cookie, write it to
> console.log and assert the correct value is in the output.
> 4. Update readme
>
> The PR would be basically the same as this one -
> https://github.com/pofider/phantom-html-to-pdf/pull/46/files
> You would probably only use object instead of array to pass cookies.
>
> What you think?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#54 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAZlydJuXhDwIfDgljj9CJJK-1HbYZOlks5rnlaOgaJpZM4MiANg>
> .
>
from phantom-html-to-pdf.
pofider
commented on July 20, 2024
Ok, sure....
The final scripts distributed to npm are created in npm prepublish or during npm tests.
=> The state of git master vs npm latest is currently the same except some minor changes done to readme which were not released yet.
from phantom-html-to-pdf.
chips5k
commented on July 20, 2024
Hmm ok, i'm not super familiar with npm publishing - just did a quick check
- the files in npm that were not in master were serverScript.js,
standaloneScript.js, but im going to hazard a guess that something is
generating those files when you publish ?
…On Tue, Mar 21, 2017 at 9:11 PM, Jan Blaha ***@***.***> wrote:
Ok, sure....
The final scripts distributed to npm are created in npm prepublish or
during npm tests.
=> The state of git master vs and npm latest is currently the same except
some minor changes done to readme which were not released yet.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#54 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZlyToXoAp2-71sir-ZsPBzsLsY_wmLks5rn6JKgaJpZM4MiANg>
.
from phantom-html-to-pdf.
chips5k
commented on July 20, 2024
Yeah ok - just ignore me, realized prepareScripts.js is what writes those
files =)
Busy week, brain not functioning so well....
On Tue, Mar 21, 2017 at 11:04 PM, callem pittard <[email protected]>
wrote:
… Hmm ok, i'm not super familiar with npm publishing - just did a quick
check - the files in npm that were not in master were serverScript.js,
standaloneScript.js, but im going to hazard a guess that something is
generating those files when you publish ?
On Tue, Mar 21, 2017 at 9:11 PM, Jan Blaha ***@***.***>
wrote:
> Ok, sure....
>
> The final scripts distributed to npm are created in npm prepublish or
> during npm tests.
> => The state of git master vs and npm latest is currently the same except
> some minor changes done to readme which were not released yet.
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <#54 (comment)>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAZlyToXoAp2-71sir-ZsPBzsLsY_wmLks5rn6JKgaJpZM4MiANg>
> .
>
from phantom-html-to-pdf.
pofider
commented on July 20, 2024
Released in 0.5.0, big thanks to @chips5k for contribution
from phantom-html-to-pdf.
Related Issues (20)
- Blurred, overlapping text when generating a PDF HOT 1
- PDF image not shown and format issue HOT 1
- Module not found: Can't resolve 'cluster' in... HOT 1
- Table Header HOT 1
- "file" argument must be a non-empty string HOT 3
- is this repo dead HOT 1
- phantomjs in electron
- occasionally I get "phantom manager could not start all workers" error HOT 4
- error occurs in electron (workerErrors) HOT 1
- Local Language Support
- fix footer
- Background color with gradient isn't working when generating via Mobile
- No support for phantom debug option
- No support for specifying TLS version
- Error: spawn EACCES HOT 5
- Cant render chinese character HOT 2
- How to do the page break in the pdf? HOT 1
- This library doesn't seem to support OnResourceRequested HOT 1
- Custom Headers is not working
- Update lodash version
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from phantom-html-to-pdf.