Giter Club home page Giter Club logo

Comments (5)

pofider avatar pofider commented on July 20, 2024

Yes, this feature is missing. We are having plans to implement it in the short time frame, however we didn't discuss the implementation details yet.

Feel free to fork and try to add some evaluations you need before printing.
https://github.com/pofider/phantom-html-to-pdf/blob/master/lib/scripts/conversionScriptPart.js#L79

from phantom-html-to-pdf.

PaddyMann avatar PaddyMann commented on July 20, 2024

I have working support for this when just running a single phantom server: #14

I've not updated conversionScriptPart.js (when is this used?) or standaloneScript.js (currently unclear on best way to return an error). It feels like the 3 files should be refactored and DRYed up...

Any tips for how to return an error in standaloneScript.js ?

from phantom-html-to-pdf.

bjrmatos avatar bjrmatos commented on July 20, 2024

conversionScriptPart.js (and serverScriptPart.js, standaloneScriptPart.js) are used in prepareScripts.js which is executed in npm postinstall hook.

don't need to return an error in standaloneScriptPart.js (well, if you really need that just throw new Error()) because this file will be running inside a child process, if it has an error it will reported in the callback of childProcess.execFile

from phantom-html-to-pdf.

bjrmatos avatar bjrmatos commented on July 20, 2024

@PaddyMann the feature is complete 😄

from phantom-html-to-pdf.

PaddyMann avatar PaddyMann commented on July 20, 2024

Had a quick play and it works great - thank you kindly sir :)

from phantom-html-to-pdf.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.