Giter Club home page Giter Club logo

Comments (3)

ganigeorgiev avatar ganigeorgiev commented on May 29, 2024 1

I'll investigate it more details tomorrow and eventually will consider preserving double extensions.

from pocketbase.

ganigeorgiev avatar ganigeorgiev commented on May 29, 2024 1

I've pushed a fix in master to take double extensions in consideration and it will be available with the next minor v0.22.10 release (most likely tomorrow or the day following it).

Regarding the hook, __hooks is a string and doesn't have StopPropagation field. To stop the hook chain in the JSVM you need to either throw an error OR return false (note that the hooks will slightly change with the refactoring).

from pocketbase.

thangngoc89 avatar thangngoc89 commented on May 29, 2024

@ganigeorgiev thank you for your quick response. In the meantime, I've found the code snippet for changing the filename on the fly using hook in #306 (comment)

I'm trying to translate it to Javascript without success.

This is what I had so far:

onFileDownloadRequest((e) => {
  fs = $app.newFilesystem();
  fs.serve(e.httpContext.response(), e.servedPath, "test.zip");
  fs.close();

  return __hooks.StopPropagation;
});

Any tips?

from pocketbase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.