Giter Club home page Giter Club logo

Comments (3)

ganigeorgiev avatar ganigeorgiev commented on June 11, 2024

Loading external resources in the Admin UI are not allowed for security reasons by the default Content security policy (CSP).

I'll think a little more on it later this week as I'm not sure what would be the best course of action here (adding exception for common websites vs enable all external iframes/images, add flag to change the csp, etc.).

from pocketbase.

ganigeorgiev avatar ganigeorgiev commented on June 11, 2024

After some more thought I decided to leave it as it is as I don't feel it is worth the risk allowing by default loading external media sources especially in the TinyMCE preview editor (see TinyMCE vulnerability fixes).

Technically loading external img-src is not a vulnerability vector on its own as the src in our cases is not allowed to be executed as JS but if the content of the field could be updated by non-admin users it could be used to try to find/track the admin IP or try to break/block the PocketBaser Admin UI in case the browser attempts to render 500MB remote img file.
For the iframe the situation is slightly more different but it too comes with some security concerns depending on where the user controlled iframe src is pointing to.

So for now I'll close the issue and classify it as a "known limitation" but with the refactoring I'll consider at least allowing users to overwrite the default CSP.

from pocketbase.

ganigeorgiev avatar ganigeorgiev commented on June 11, 2024

Side-note: In the future we'll replace TinyMCE entirely due to its recent v7 license change - tinymce/tinymce#9496.

from pocketbase.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.