Report faulty nodes. about hbbft HOT 2 CLOSED

Errors can be logged at least in HoneyBadger in those places where there are TODOs to start logging something. So far there are 3 such TODOs:

1. an incorrect message from a known sender:
   

   hbbft/src/honey_badger.rs

   Line 238 in e0a85a5

   // TODO: Log the incorrect sender.

2. an incorrect ciphertext computed for a known proposer node:
   

   hbbft/src/honey_badger.rs

   Line 412 in e0a85a5

   // TODO: Log the incorrect node `j`.

3. decryption failure for a konwn proposer:
   

   hbbft/src/honey_badger.rs

   Line 435 in e0a85a5

   // TODO: Log the decryption failure.

each related to failures related to processing encrypted messages or ciphertexts. However the same logging improvement can be applied to other places possibly in other algorithms too where we, say, return Ok(()) or simply () when some check fails, and the reason for that failure is likely to be some remote node that we can identify on the spot.

from hbbft.

(Note that the log shouldn't just be command line output; the user should be able to programmatically learn about malicious nodes and act on it.)

from hbbft.