Use error-chain. about hbbft HOT 3 CLOSED

Yup, sorry, that is definitely true. You just lose the "error-chaining" and implicit impl From<rse::Error> for Error benefits of using error-chain. For now, we can just use a tuple enum in the ReedSolomon variant. If you are interested, the Issue and corresponding PR in reed-solomon-erasure can be found here (the author was very quick to respond):
Issue
PR

from hbbft.

For the moment, error-chain can't be used by hbbft because we depend onreed_solomon_erasure::Error which doesn't implement the std::error::Error trait, all error types that get chained together by error-chain must implement std::error::Error.

I'm going to file an Issue with reed_solomon_erasure requesting the feature. So at least for now, hbbft is stuck with error enums. If the issue isn't picked up, I might be able to submit a PR implementing std Error.

from hbbft.

But an error variant can contain any kind of parameter, can't it? So due to that limitation the ReedSolomon(reed_solomon_erasure::Error) variant wouldn't be in foreign_links, but it could still live in the errors section for now?

(That said, I agree that not implementing the Error trait is an omission that should be fixed in the reed_solomon_erasure crate!)

from hbbft.