v9 `run -r` runs in wrong order about pnpm HOT 4 OPEN

+1, I have the same bug in one of my workspaces, worked perfectly with the last pnpm 8.15.7.

from pnpm.

Hi! in the package.json of @nighttrax/bar, is there any reason the local dependency is not specified with the workspace: prefix? If it's for package publishing, you can use pnpm publish and pnpm will remove the prefix in the published package. (same with pnpm pack)

{
  "dependencies": {
    "@nighttrax/foo": "workspace:~1.0.0"
  }
}

With this change, in my side the command runs correctly (it has an error in a nextjs app, but does not seem related to pnpm). Thanks in advance!

EDIT:
The reason for the issue in the v9 update is a breaking change. More information here.
link-workspace-packages is now false by default.

from pnpm.

@nachoaldamav thanks for spotting that, I guess it's just a relic from the beginning of the repo. Using the workspace: protocol does indeed fix the issue.

Regarding the link-workspace-packages breaking change, I think something else is breaking the behaviour of run -r. The lockfile suggests that the package is linked, and AFAICT pnpm i with v9 doesn't change that part of the lockfile while upgrading to the v9 format. Checking node_modules corroborates that. Moreover, building packages/foo manually before building packages/bar fixes the error, so it looks like an execution order problem with pnpm -r.

The use case from https://pnpm.io/workspaces fits my repo:

By default, pnpm will link packages from the workspace if the available packages match the declared ranges. For instance, [email protected] is linked into bar if bar has "foo": "^1.0.0" in its dependencies and [email protected] is in the workspace.

However, that only mentions linking, which seems to still work correctly in v9.

Since using workspace: fixes the problem, is there some other breaking change for v9 run -r that doesn't consider foo: ~1.0.0 a workspace dependency anymore?

Edit: hmm, setting link-workspace-packages=false makes run -r work as expected with v9. The docs seem misleading to me, as they talk about linking and node_modules, not about running scripts.

from pnpm.

EDIT: The reason for the issue in the v9 update is a breaking change. More information here. link-workspace-packages is now false by default.

@nachoaldamav Thanks for this, adjusting this option works for me 👍

I cannot switch (yet) to pnpm publish and workspace:* everywhere because semantic-release doesn't officially support pnpm to publish packages.

from pnpm.