Giter Club home page Giter Club logo

Comments (12)

DonKirkham avatar DonKirkham commented on August 15, 2024 2

The maintenance of this image would be a nightmare and the ROI would not be worth the effort needed to support such an isolated use-case. With the elimination of the local workbench, trying to develop SPFx project while offline is not possible for SPO since the hosted workbench or live SPO site is required. I'm not sure how on-prem dev would work either, unless your SP dev farm is running on a local container/VM on your device.

from docker-spfx.

alexalexpod avatar alexalexpod commented on August 15, 2024 1

Definitely OK, I very appreciate your decision.
Thank you very much.

from docker-spfx.

waldekmastykarz avatar waldekmastykarz commented on August 15, 2024

Thanks for reaching out. What do you mean exactly with Yeoman default template? Do you mean, you would like to have the image contain all packages required to scaffold each combination of a SharePoint Framework project (eg. on-prem vs. on-line, web parts vs. extensions, React vs. Knockout vs. no framework) so that you can use it offline?

from docker-spfx.

alexalexpod avatar alexalexpod commented on August 15, 2024

Thank you for the answer.
I mean that the image should include all packages required to scaffold a few of the most used combinations, like: Default Name --> SP2016 onwards --> Current Folder --> Default WebPart Name and Description --> React/NoFramework.
On my opinion, this is crucial for on-premises and offline (particularly) SPFx development.
Thanks, Alex.

from docker-spfx.

waldekmastykarz avatar waldekmastykarz commented on August 15, 2024

I can totally understand your suggestion. I wouldn't replace the existing image, but will see if we could create a separate one. That way everyone can choose if they want to use the one with precached packages or without. I'll leave this issue open until I know more if this is possible, ok?

Once again, thank you for reaching out 👍

from docker-spfx.

shurick81 avatar shurick81 commented on August 15, 2024

as far as I know, yeoman was a part of the latest docker image versions, or is there still an issue @alexalexpod?

from docker-spfx.

waldekmastykarz avatar waldekmastykarz commented on August 15, 2024

@shurick81 the suggestion was to include all packages required for a scaffolded project in the image. Right now we have Yeoman, the generator and gulp but not the actual SPFx libraries, which was the request. Thinking of it, the question is if we should follow this path, as it would mean that we'd need to regularly refresh the image to fix any issues with any of the hundreds dependencies in the tree.

from docker-spfx.

shurick81 avatar shurick81 commented on August 15, 2024

I see now, and that would probably something we do in a separate image, right?

from docker-spfx.

waldekmastykarz avatar waldekmastykarz commented on August 15, 2024

Correct, that was the idea. The question is though, if it's still relevant and worth the effort to maintain the downstream dependencies. Since we just got this one request almost 4 years ago, my gut feeling says to hold off working on it until we see more demand for it.

from docker-spfx.

shurick81 avatar shurick81 commented on August 15, 2024

But is not it like every project might have different package versions required? For example, two projects might be skaffolded using spfx 1.13.1 but they have a bit different versions of the used packages?

@alexalexpod, is it still demanded for you?

from docker-spfx.

waldekmastykarz avatar waldekmastykarz commented on August 15, 2024

I think the challenge is with the dependencies changing over time. I don't know if SPFx locks on specific versions of its downstream dependencies or not. If it doesn't, then a project you create today, could theoretically use different dependencies than a project you created yesterday.

from docker-spfx.

shurick81 avatar shurick81 commented on August 15, 2024

the way to maintain it will be scaffolding projects and keeping cache files or how does it exactly work with modules?

I wonder how a user will select the image that is needed with specific module versions...

for example, the image versions can be like this, right?

  • spfx:1.14.0-react-16.13.1-office-ui-fabric-react-7.174.1

and we could end up with like thousands of different combinations? Otherwise how we predownload these modules to the image? I'm really curious to make some POC in order to verify the viability.

from docker-spfx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.