Regression: Shader info logs are not reported on compile error about pmp-library HOT 3 CLOSED

Thanks for spotting this!

get_info_log always uses pid_, which is ok for linker errors, but it should use the local shader id in case of compile errors.

It seems that shaders that do not compile do not get deleted properly in cleanup(), since their id is added to shaders_ only after successful compilation. Probably we should add id to shaders_ after creation, not after compilation, in compile() or load_and_compile().

@dsieger any thoughts?

from pmp-library.

I'll take a look

from pmp-library.

It seems that shaders that do not compile do not get deleted properly in cleanup(), since their id is added to shaders_ only after successful compilation. Probably we should add id to shaders_ after creation, not after compilation, in compile() or load_and_compile().

Yep, storing the shader ID directly after creation seems much cleaner. Changed in 09cc75d.

from pmp-library.