Comments (8)
CodyJasonBennett
commented on May 21, 2024
The minimum supported version of react-native (an optional peer dep) doesn't support react 18 which is clashing here because of an NPM v7 policy.
You can try the --force or --legacy-peer-deps flags without issue in your case, but I'll try to push out a reconciler upgrade which will align everything to react 18+.
from react-ogl.
CodyJasonBennett
commented on May 21, 2024
Should be fixed in v0.7.0.
from react-ogl.
Aqro
commented on May 21, 2024
Hi,
Thanks for the quick fix. Unfortunately, it hasn't changed anything as I still got issue when installing react-ogl on a fresh Next app. (--legacy-peer-deps worked like a charm but I'd like to avoid these extra parameters when deploying)
Here is the part of the code where the error appeared:
...
144 timing idealTree:node_modules/react-ogl Completed in 66ms
145 silly fetch manifest [email protected]
146 silly fetch manifest expo-asset@*
147 silly placeDep ROOT [email protected] OK for: @expo/[email protected] want: ^0.0.3
148 silly placeDep ROOT [email protected] OK for: [email protected] want: *
149 silly placeDep ROOT [email protected] OK for: @expo/[email protected] want: ^2.1.1
150 timing idealTree Completed in 245ms
151 timing command:i Completed in 247ms
152 verbose stack TypeError: Cannot read properties of null (reading 'children')
152 verbose stack at CanPlaceDep.checkCanPlaceCurrent (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/can-place-dep.js:253:35)
152 verbose stack at CanPlaceDep.checkCanPlace (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/can-place-dep.js:157:27)
152 verbose stack at new CanPlaceDep (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/can-place-dep.js:114:26)
152 verbose stack at PlaceDep.place (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/place-dep.js:123:19)
152 verbose stack at new PlaceDep (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/place-dep.js:73:10)
152 verbose stack at /usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:990:31
152 verbose stack at Array.map (<anonymous>)
152 verbose stack at Arborist.[buildDepStep] (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:990:8)
152 verbose stack at async Arborist.buildIdealTree (/usr/local/lib/node_modules/npm/node_modules/@npmcli/arborist/lib/arborist/build-ideal-tree.js:218:7)
152 verbose stack at async Promise.all (index 1)
153 verbose cwd /Users/arno/Dev/my-app
154 verbose Darwin 21.6.0
155 verbose node v16.15.0
156 verbose npm v8.18.0
157 error Cannot read properties of null (reading 'children')
158 verbose exit 1
159 timing npm Completed in 291ms
160 verbose unfinished npm timer reify 1661511638158
161 verbose unfinished npm timer reify:loadTrees 1661511638159
162 verbose unfinished npm timer idealTree:buildDeps 1661511638216
163 verbose unfinished npm timer idealTree:node_modules/@expo/browser-polyfill 1661511638401
164 verbose code 1
from react-ogl.
CodyJasonBennett
commented on May 21, 2024
I'll take another look at this, seems to be coming from a native-only polyfill. Unfortunately, it may not be very actionable on our end since NPM is misunderstanding peer deps and version ranges as per semver. I might suggest Yarn or a package manager that correctly handles this in the meantime.
from react-ogl.
CodyJasonBennett
commented on May 21, 2024
I removed the polyfill in v0.8.0 to sidestep these issues. Should be good now, we'll have to vendor polyfills like R3F does if we change our mind.
from react-ogl.
Aqro
commented on May 21, 2024
I feel like a chewing-gum stuck under your shoe but … 😬 npm install now works correctly but there is an issue with constants in the reconciler it doesn't find. 😅
error - Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/arno/Dev/my-app/node_modules/react-reconciler/constants' imported from /Users/arno/Dev/my-app/node_modules/react-ogl/dist/reconciler.mjs
Did you mean to import react-reconciler/constants.js?
at new NodeError (node:internal/errors:372:5)
at finalizeResolution (node:internal/modules/esm/resolve:437:11)
at moduleResolve (node:internal/modules/esm/resolve:1009:10)
at defaultResolve (node:internal/modules/esm/resolve:1218:11)
at ESMLoader.resolve (node:internal/modules/esm/loader:580:30)
at ESMLoader.getModuleJob (node:internal/modules/esm/loader:294:18)
at ModuleWrap.<anonymous> (node:internal/modules/esm/module_job:80:40)
at link (node:internal/modules/esm/module_job:78:36) {
code: 'ERR_MODULE_NOT_FOUND',
page: '/'
from react-ogl.
CodyJasonBennett
commented on May 21, 2024
I fixed the last of the ESM issues in v0.8.1.
from react-ogl.
CodyJasonBennett
commented on May 21, 2024
This looks to be resolved on my end, but do let me know if there are any withstanding issues.
from react-ogl.
Related Issues (15)
- Can't pass custom renderer constructor to state HOT 1
- [critical] switching instance removes linkage to parent and drop `attached` node reference
- [feature] Dispose HOT 1
- [feature] Custom GL required class HOT 3
- on* handlers must be saved for custom props HOT 4
- [bug] React 18 refs type HOT 1
- useLoader equivalent HOT 1
- codesandbox CI HOT 1
- [Degradation] Attachements detaching invalid HOT 1
- react-devtools crash HOT 10
- Crash when try use texture from Unit8Array. HOT 1
- Raycast not working when node has parent HOT 2
- OGL TextureLoader and react-ogl useLoader are incompatible HOT 1
- [critical] Uniform diff check should update only known uniforms HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-ogl.