Giter Club home page Giter Club logo

Comments (6)

pmario avatar pmario commented on June 19, 2024

It doesn't depend on the link. ...

The plugin compares the browser URL. If it is exactly the same 2 times, imo there should be a warning. If you edit tab 1, then tab2 ... you'll have different version. So saving the stuff to the same xx.html file will cause data loss.

If you don't have the same URL ... there may be a bug. ...

from file-backups.

pmario avatar pmario commented on June 19, 2024

Clicking once opens the location in another tab as expected.

Can you give an example?

from file-backups.

furicle avatar furicle commented on June 19, 2024

Let's say I have a TW with a link to a pdf.

[[file:img/test.pdf]]

First time I click the link, it opens the pdf in a new tab as expected.

Then I go back to the wiki and click the link again.... it opens the pdf in a second tab. Also as expected. But it throws up your big red warning box.

That should not happen, unless it's a TW that's opened twice.
Opening a pdf, or a jpg, or a website or anything else shouldn't get your box, just TWs.

Is that explained better? I could make a sample TW I guess, but I'm not sure that would help explain.

from file-backups.

pmario avatar pmario commented on June 19, 2024

Then I go back to the wiki and click the link again.... it opens the pdf in a second tab. Also as expected. But it throws up your big red warning box.

That should not happen, unless it's a TW that's opened twice.
Opening a pdf, or a jpg, or a website or anything else shouldn't get your box, just TWs.

Ah. OK I'll need to check this. ... deffinitely unwanted behaviour. ... But I'm not sure if there's an easy fix. ...

from file-backups.

pmario avatar pmario commented on June 19, 2024

@furicle ... please check out the latest version: https://addons.mozilla.org/en-US/firefox/addon/file-backups/

I did wanted to sign it and distribute it as a beta with github, but it seems I can't have both. listed and self-signed :/

from file-backups.

furicle avatar furicle commented on June 19, 2024

Looking good!

Can't duplicate the issue now, using 0.3.5

(FF 58.02 x64 on Win10)

from file-backups.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.