Giter Club home page Giter Club logo

Comments (10)

GiovanniBussi avatar GiovanniBussi commented on August 25, 2024

This is one of the few regtests that (for me) fail on linux. I think that is due to numerical errors. Maybe we could check if writing the reference histogram with less digit helps.

from plumed2.

gtribello avatar gtribello commented on August 25, 2024

OK I added an option to specify the file format for histogram. It was always working on my computer so this made no difference to me. Can someone try it on a computer where it wasn't working please? Thanks

from plumed2.

GiovanniBussi avatar GiovanniBussi commented on August 25, 2024

I still get the error (with intel c++ on mac).
I tried with FMT=%8.1f and still the two compilers give different results.
With FMT=%8.0f I get a surprising error:
+++ Internal PLUMED error
+++ file Grid.cpp, line 170
+++ message: assertion failed indices[i]>=0 && indices[i]<nbin_[i]

Maybe this is related to #19 ?

from plumed2.

gtribello avatar gtribello commented on August 25, 2024

Firstly, the grid spacing is 0.005, if you output with anything less than %8.3f then there are always going to be problems. I therefore think the error with %8.0f is a non starter.

What precisely fails with this test. Do you get a mismatch for just histo, just analysis.0.histo or both?

from plumed2.

GiovanniBussi avatar GiovanniBussi commented on August 25, 2024

I agree that the output is a nonsense with %8.0f. Still the code should NOT crash.

Anyway, with %8.4f I get a mismatch in both files with intel c++

from plumed2.

gtribello avatar gtribello commented on August 25, 2024

The grid goes from 0.2 to 1.2 in the x direction. The grid is read as the second histogram output is the sum of the histograms from the first half of the simulation and the second half. If you put %8.0f the first x value is 0, which is outside the range. Hence the crash with that error. If we want to do something to fix the %8.0f error I think we have to make sure the grid spacing can be output with the format. I don't know how to do that though.

from plumed2.

GiovanniBussi avatar GiovanniBussi commented on August 25, 2024

Got it! I did not realize it was re reading it... Thanks! Still it would be nice to make the regtest pass with different compilers I will try to play with parameters tomorrow and ask you if they make sense

from plumed2.

GiovanniBussi avatar GiovanniBussi commented on August 25, 2024

I think I found it. Intel c++ with -O changes the stream of random numbers thus produce a different traj with simplemd. If I compile only tools/Random.cpp with -O0 the regtest is passed. I will try to fix it

from plumed2.

gtribello avatar gtribello commented on August 25, 2024

Hurah! As far as I am concerned that means I am not to blame :-)

from plumed2.

GiovanniBussi avatar GiovanniBussi commented on August 25, 2024

@davidebr can you check if it is ok also on your machine?

from plumed2.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.