Giter Club home page Giter Club logo

Comments (6)

mattwcole avatar mattwcole commented on May 20, 2024 1

Agreed it would be more useful to allow this in UID field. I've put up a PR, feel free to amend as needed.

from strapi-plugin-sitemap.

boazpoolman avatar boazpoolman commented on May 20, 2024 1

That should not be an issue anymore because I've altered the regex of the UID field to allow slashes.
That said: I want to add a couple more things before making a new release to npm. Next release will likely be somewhere at the start of next week.

from strapi-plugin-sitemap.

boazpoolman avatar boazpoolman commented on May 20, 2024

This looks great. I was kind of hoping that this 'prefix' feature would be added to the UID field type directly. Nonetheless this adds a lot of value to the plugin. I'll test it out. Could you create a PR?

from strapi-plugin-sitemap.

boazpoolman avatar boazpoolman commented on May 20, 2024

I made a couple of changes, most primarily:

  • The regex for the custom entry slug field allows '/', which makes the area field here redundant.
  • The area field is now an InputUID component (just like slug) to prevent incorrect input.

See #9

from strapi-plugin-sitemap.

mattwcole avatar mattwcole commented on May 20, 2024

Nice job, thanks for fixing. The only issue I see with making the area field a UID too is if a URL path needs multiple slashes eg https://my-site.com/articles/help/my-strapi-help-article1 (probably more likely for custom entries). Not my use case though, so this fix should unblock us.

from strapi-plugin-sitemap.

boazpoolman avatar boazpoolman commented on May 20, 2024

Fixed in v1.1.2 (https://github.com/boazpoolman/strapi-plugin-sitemap/releases/tag/1.1.2)
Thanks for the work :)

from strapi-plugin-sitemap.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.