Images don't provides the "Transform" tab that archetypes had. about plone.app.contenttypes HOT 27 CLOSED

To implement the features from ATCTImageTransform for the images in plone.app.contenttypes should not be too hard but I wonder if it would be useful. I don't want us to be strict about feature-equality if we could agree that this feature is useless.

I personally consider the available transforms completely useless. Who in their right mind uploads images that are upside down or wants to rotate them in Plone when every OS can do this much more efficiently? What I'd much rather want in a CMS is image-cropping. This and Products.ImageEditor to facilitate this and much more. There is also the PLIP https://dev.plone.org/ticket/10174 for plone.app.imagecropping.

from plone.app.contenttypes.

Ack, the current ATCTImageTransform is useless. +1 for using p.a.imagecropping by default. in CMS custom cropping (on a per-scale base!) is a very important and powerful feature.

from plone.app.contenttypes.

This feature will not be reimplemented. If you need this feature consider using plone.app.imagecropping.

from plone.app.contenttypes.

Not having the auto rotating transform is a bit hard to explain to people, as software on the computer does this by default, customers don't get it, they upload a photo and it's upside down or rotated left/right all of a sudden.

from plone.app.contenttypes.

@maartenkling nice blogpost :-)
I actually did not know about the whole "we rotate automatically"-functionality and thought that code is only there for the weird transform-form. Enabling this feature for DX would be much appreciated.

from plone.app.contenttypes.

Hi, does plone.app.imagecropping provide image rotating ?

On Wed, Oct 16, 2013 at 2:29 PM, Philip Bauer [email protected]:

@maartenkling https://github.com/maartenkling nice blogpost :-)
I actually did not know about the whole "we rotate
automatically"-functionality and thought that code is only there for the
weird transform-form. Enabling this feature for DX would be much
appreciated.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-26413432
.

Thomas Desvenain

Téléphone : 09 51 37 35 18

from plone.app.contenttypes.

@tdesvenain: no, it does not.

from plone.app.contenttypes.

I agree that transform tab is not very impressive or even nice, but it
saves a lot of time when you upload images as you always have some that are
not well positioned. I hope this feature will be kept...

On Wed, Oct 16, 2013 at 2:55 PM, Philip Bauer [email protected]:

@tdesvenain https://github.com/tdesvenain: no, it does'nt.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/32#issuecomment-26414982
.

Thomas Desvenain

Téléphone : 09 51 37 35 18

from plone.app.contenttypes.

@maartenkling Do you think you'll have time to make a pull for http://blog.fourdigits.nl/auto-rotate-dexterity-images-based-on-exif-information ? If not, what's the used exif-library? (It's not defined in the blog post.)

from plone.app.contenttypes.

Ok. It seems to be ExifRead.

from plone.app.contenttypes.

@datakurre will try to make some time, will even write some nice post about the profile portrait img having the same problem

https://github.com/plone/Products.ATContentTypes/blob/master/Products/ATContentTypes/lib/imagetransform.py
#third party extension
import exif

from plone.app.contenttypes.

this was moved to namedfile or something like that sometime ago i think. this should not only be in p.a.c but available for all image uploads

from plone.app.contenttypes.

👍

(But sorry about accidentally closing this. The fix for plone.namedfile still is not "Transform tab", because it does not have manual UI.)

from plone.app.contenttypes.

👍 keep up the good work!

from plone.app.contenttypes.

Imo a transform tab should be a generic behavior, not part of p.a.ct.

It also could be a good citizen and dont interfere with plone.app.imagecropping. Or be part of it?

from plone.app.contenttypes.

Was there any resolution on whether p.a.contenttypes should handle automatic rotation based on EXIF data? It seems like a very useful function to be able to provide separately to a manual transform tab.

from plone.app.contenttypes.

@ezvirtual It should! I would prefer it if that would happen in plone.namedfile so that all types that use a image-field get this feature. There is no implementation yet. Pull-request are very welcome!

from plone.app.contenttypes.

I had pull for this a long time ago, but I really thought someone added it then into plone.namedfile and did nothing. #176

from plone.app.contenttypes.

👍

from plone.app.contenttypes.

Oh. I cannot find that in plone.namedfile. Can someone point me at it?

from plone.app.contenttypes.

@datakurre you wrote "@maartenkling confirmed that this is indeed implemented in plone.namedfile." @maartenkling: is that true?

from plone.app.contenttypes.

Maybe he just said that he'd do it or I misunderstood something in some other way.

from plone.app.contenttypes.

nope cant find it any more .... i didnt make a pull request for it, thought @datakurre did...

from plone.app.contenttypes.

#32 (comment)

:D

from plone.app.contenttypes.

I had already made an in-house release with this, so when I thought that @maartenkling had already moved that code to plone.namedfile I did nothing.

from plone.app.contenttypes.

Hey all, I went ahead and had a go at implementing this in plone.namedfile any feedback or input appreciated. Any thoughts on whether it's necessary for plone.namedfile to support this functionality for ATContentTypes as well?

from plone.app.contenttypes.

I don't think this is an issue anymore. Autorotation works fine, meanwhile.

from plone.app.contenttypes.