Milestone Card hover state: Add outline for emphasis and to indicate clickability about starmap HOT 9 CLOSED

Let's rationalize this as part of this thread: https://filecoinproject.slack.com/archives/C0418TBQ9CH/p1668131525690269

I get your argument, but not sure if whole card clickable is the right design anymore based on what I say in that thread

from starmap.

TBF - what you're going for with visual cues is great and maybe is P0 if easy enough - I'm now saying I'm not sure this is the right visual cue if we change how clicks work

from starmap.

@juliaxbow can this be P1?

from starmap.

I'll let @SgtPooki chime in on how easy this is to accomplish (seems like it should be straightforward but what do I know!) BUT I prefer to leave as P0. As for why:

• It will allow users to understand what they can or can't click into and learn how to interact with the roadmap.
• It will also help avoid #62 (user tries to click into a child milestone but it doesn't behave as expected because it is the final milestone)

from starmap.

@SgtPooki per your slack and the convo in this issue, if we need to downgrade this to P1 we can

from starmap.

@juliaxbow - did you land on how to handle the multiple click actions we want? How does that impact this issue?

from starmap.

Here are what I'm thinking are our options. In all options, the entire card should be clickable with another element linking to GitHub. I'm planning to do some quick a/b testing tomorrow but let me know if you have a preference. I'm leaning towards option 1 or 2.

1. CURRENT: GitHub logo in top right corner linking to issue
   Pro: I think this is the most visually appealing and least cluttered option, especially if there is a lot of text in the issue name
   Con: May not unclear to users that GitHub logo links out. Relatively small clickable space.

2. Link out icon next to Issue name
   Pro: Light on card content and uses an icon people are familiar with
   Con: People may not know what the link leads to (since no GitHub text or logo). Because of its proximity to the issue title, users may think that clicking on the card and clicking on the icon will have the same response.

3. Added text "View in GitHub"
   Pro: Consistent with primary link to GitHub in header. Action is made explicit
   Con: Text heavy. Limits content that we can add to the card

I also explored the idea of a kebab/ellipsis menu but rejected it given that there would be only two actions we're allowing.

from starmap.

continuing discussion for github link placement in #74

from starmap.

also related to #61

from starmap.