Handle all errors appropriately about starmap HOT 7 OPEN

@juliaxbow - generally speaking, I think the representation looks great. Not sure on this point: should the error list start out collapsed with only an indicator that there are errors visible? I think about cases where Molly is wanting to view all engres roadmaps and maybe there's 10 errors - at which point what does that do to visiblity of the rest of stuff without errors?

from starmap.

Minor suggestion: For the "Issues with roadmap" dropdown, instead of only the chevron on the right [circled in red] being clickable, I expected the entire rectangle [outlined in red] to be clickable.

from starmap.

moved to description

from starmap.

Re: Invalid github metadata, Reid and I talked about including an error summary. Let me know what you think, @wilkyr31d and @SgtPooki let me know how feasible you think this is.

Included dark/light mode below. Also included two options for presenting the errors: single column or two column. A row with github link and description of error makes sense if the error description is minimal. If the error description will be longer, I'd switch to the single column view. Can play around with wording, too, but should align on standard error messages.

Dark Mode GitHub Metadata Error Summary (Rows)

Dark Mode GitHub Metadata Error Summary (Single Column)

Light Mode GitHub Metadata Error Summary (Single Column)

Light Mode GitHub Metadata Error Summary (Rows)

from starmap.

Agreed on allowing users to collapse the error log (I suggest we allow collapsing and remove the ability for users to close out the error log). Convo happening over slack.

I also updated this issue to include a link to error mapping in Notion

from starmap.

Do we want to consider an error where an issue's ETA is earlier than one of it's children? I think adding that at some point could be really useful to debug complex roadmaps.

from starmap.

Actions items left to close this out:

• Make "Issues with roadmap" entire header clickable to expand/collapse
• Ensure an error shows when ETA is missing, but is required
• Ensure error does not show if ETA is missing for currently viewed root issue
• Ensure error does not show if ETA is missing (on detail view) for groupParent issue

from starmap.