It should be possible to overwrite the slick drivers in application.conf about play-slick HOT 7 CLOSED

I have a solution for this using the Scala 2.10 reflection API. Loading custom Slick drivers works (I tested the MariaDB JDBC driver with the MySQL Slick driver).
However, there is the issue of configuration: Right now, the only play-slick configuration option is slick.default="models.*" (or similar). Like this, slick.default is already defined as a string, and it is impossible to set a key slick.default.driver.
Also, SlickDDLPlugin reads all children of the slick configuration key, so a simple hack like setting slick.driver=scala.slick.H2Driver won't work.

Possible solutions would be to work around this with two root-level configuration keys, à la

slick.default="models.*"
slickdrivers.default="scala.slick.driver.MySQLDriver"

I think this is sort of hacky, though. A cleaner solution would be to change the configuration to something like this:

slick.default.models="models.*"
slick.default.driver="scala.slick.H2Driver"

Any thoughts on this?

from play-slick.

I like it :) there is a possibility you get a conflict between the url driver and this setting but since it is optional it is fair to assume that the user knows what he is doing.
Want to create a PR?

Carsten Brachem [email protected] wrote:

I have a solution for this using the Scala 2.10 reflection API. Loading
custom Slick drivers works (I tested the MariaDB JDBC driver with the
MySQL Slick driver).
However, there is the issue of configuration: Right now, the only
play-slick configuration option is slick.default="models.*" (or
similar). Like this, slick.default is already defined as a string,
and it is impossible to set a key slick.default.driver.
Also,
SlickDDLPlugin
reads all children of the slick configuration key, so a simple hack
like setting slick.driver=scala.slick.H2Driver won't work.

Possible solutions would be to work around this with two root-level
configuration keys, à la

slick.default="models.*"
slickdrivers.default="scala.slick.driver.MySQLDriver"

I think this is sort of hacky, though. A cleaner solution would be to
change the configuration to something like this:

slick.default.models="models.*"
slick.default.driver="scala.slick.H2Driver"

Any thoughts on this?

---

Reply to this email directly or view it on GitHub:
#25 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

from play-slick.

I agree on the possible conflict: this is the same thing that you have with plain Slick. If you wanted to, you could choose the wrong database driver (or create a custom nonsense driver). It's great of play-slick that it removes the chance to get it wrong for most configurations, but if someone wants to, they should be able to choose their Slick driver.

But:
I cannot create a PR yet because I don't know how to proceed on the configuration issue. I have suggested two possible solutions, one with the two root-level configuration keys, and the other one that is cleaner (everything is unter slick.*), but changes the current configuration and breaks all current projects using play-slick.
I'd happily implement either of these solutions (or something completely different). But this issue is too big for me to decide on; also, I don't have the necessary insight into the project and its plans to make an informed suggestion. What's your stand on this?

from play-slick.

Ok - right. i will have a look at it tomorrow

from play-slick.

I've done that in my fork: v6ak@3690072

There is the pull request: #110

from play-slick.

Awesome stuff! Thanks for this! Will review on Wednesday and put out a new if there is no hick-ups.

"Vít Šesták" [email protected] wrote:

I've done that in my fork:
v6ak@3690072

There is the pull request:
#110

---

Reply to this email directly or view it on GitHub:
#25 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

from play-slick.

Closing this since PR is merged

from play-slick.