I've noticed there is a TWEEN global registered in package.json. Does engine actually

If you remove that, you get: <div class="highlight highlight-source-shell notransl

package.json globals about engine HOT 7 CLOSED

LeXXik commented on May 28, 2024

package.json globals

from engine.

Comments (7)

willeastcott commented on May 28, 2024

If you remove that, you get:

C:\dev\engine>npm run lint

> [email protected] lint
> eslint --ext .js,.mjs extras scripts src test utils rollup.config.mjs


C:\dev\engine\scripts\animation\tween.js
  200:22  error  'TWEEN' is not defined  no-undef
  202:22  error  'TWEEN' is not defined  no-undef
  273:31  error  'TWEEN' is not defined  no-undef
  315:9   error  'TWEEN' is not defined  no-undef

✖ 4 problems (4 errors, 0 warnings)

from engine.

LeXXik commented on May 28, 2024

I don't think that is a correct class? TWEEN is the original Tween.js:
https://github.com/tweenjs/tween.js

While PlayCanvas is (or at least it should be) using own one, which is Tween:
https://github.com/playcanvas/playcanvas-tween/

from engine.

willeastcott commented on May 28, 2024

engine/scripts/animation/tween.js

Line 273 in 44dda5a

tweenInstances[idx] = new TWEEN.Tween(startValue)

That script is using the original Tween.js.

from engine.

LeXXik commented on May 28, 2024

Why does it use a third party library, when the engine has own tool that does the same?

from engine.

willeastcott commented on May 28, 2024

Because:

The playcanvas-tween library is a separate repo and IMHO, it is 'bad' in that it hacks/modifies the Entity and AppBase APIs.
Tween.js is awesome! Why not use it? Why re-invent the wheel? So I added a nice, clean Tween.js wrapper script for people to use that doesn't hack engine internals.

from engine.

LeXXik commented on May 28, 2024

I have nothing against Tween.js, I also think it is awesome :) Maybe it is time to consider deprecating playcanvas-tween then?

from engine.

willeastcott commented on May 28, 2024

I think we should...

from engine.

Recommend Projects