Giter Club home page Giter Club logo

Comments (8)

Saulis avatar Saulis commented on June 8, 2024

Can't see any workarounds – this function should probably be refined a bit to create custom-style elements only when css has Polymer css mixins or properties present.

from angular-polymer.

Splaktar avatar Splaktar commented on June 8, 2024

I have been seeing issues with material2 styles and it looks like this is the culprit. It's unfortunate that this is still sitting here unassigned :(

@Saulis Do you know how to detect if the css "has Polymer css mixins or properties present"? I'm guessing that this would need something more than just looking for @apply and CSS Variables? But wouldn't inspecting all of the contents of the style element come at a performance cost?

We've had to re-declare our material2 styles inside of Angular components to get them to work again. It's pretty ugly.

from angular-polymer.

Splaktar avatar Splaktar commented on June 8, 2024

Actually, I debugged my issues further and with or without the is="custom-style" there was no change in behavior or Material2 styles. I found that I needed to configure Material2's new theming system for my app. After that, everything is working as expected with styling.

from angular-polymer.

jaichandra avatar jaichandra commented on June 8, 2024

@Splaktar can you share some details on how you configured material theming system to get it to work with polymer? Would be very helpful.

from angular-polymer.

logvi avatar logvi commented on June 8, 2024

The same issue for me. Can you please describe how to solve it?

from angular-polymer.

Splaktar avatar Splaktar commented on June 8, 2024

@jaichandra @logvi you can see the repo here and I have a blog post about upgrading from Angular 2 RC.4 and getting this working again here.

from angular-polymer.

logvi avatar logvi commented on June 8, 2024

@Splaktar Hm, it doesn't help me :(. I added custom theme but styles still overwritten by is="custom-style"

from angular-polymer.

Splaktar avatar Splaktar commented on June 8, 2024

@logvi the styles aren't overwritten, they just get the is="custom-style" attribute added to them. It doesn't break anything for me. What problem are you seeing exactly?

from angular-polymer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.