Bug: "Remove Multiple Spaces" rule ignores >1 spaces inside of tables about obsidian-linter HOT 5 OPEN

The issue with removing multiple spaces is that it will remove spaces before and after text in a table as well. It can be handled, but that would take treating tables as special and then handling them as a one off. That is possible, but it would likely be some time before I could take a look at it assuming there is not a lot of desire for this from the community.

However, I would be fine with accepting a PR for this.

from obsidian-linter.

Hey @redactedscribe . I am not sure that this is a bug. If I recall, the reason tables are not affected is because removing multiple spaces in a table removes styling added to those tables like making sure all rows have the same length.

I am not sure I would want to change that behavior since it could mess up table styling which I have no intention of supporting in the Linter.

from obsidian-linter.

I understand your concerns @pjkaufman, however I do not style my tables so fixing >1 spaces would not be a problem in my case.

(Edit: By style I mean align the table using spaces. I do "style" it by having a space before and after vertical bars, which might require some support and is something I did not consider at first.)

Is "Remove Multiple Spaces" the only rule which doesn't run on tables? If so, Linter already supports tables you could say, it just doesn't touch spacing.

If that holds true, then instead of hardcoding skipping over the "Remove Multiple Spaces" rule, we could have an "Ignore rules from table linting" option with a list filter where we can add rule aliases (with "remove-multiple-spaces" listed by default).

This would then at least give us the option to remove "remove-multiple-spaces" if we don't want space-aligned tables in source.

from obsidian-linter.

It would mess with the following table styling:

| Foo        | Bar                                                                                                        |
| --------- | -------------------------------------------------------------------------- |
|     Hello | World! Some double spaces and a link [here is link text1](link_here). |

would become

| Foo | Bar |
| --------- | -------------------------------------------------------------------------- |
| Hello | World! Some double spaces and a link [here is link text1](link_here). |

from obsidian-linter.

The issue with removing multiple spaces is that it will remove spaces before and after text in a table as well.

I understood this, which is why I suggested keeping the behaviour the same but letting users who don't want/need nicely spaced tables in their Markdown to opt out.

That is possible, but it would likely be some time before I could take a look at it assuming there is not a lot of desire for this from the community.

My assumption would be that some users do format their tables nicely, and others don't bother (which my guess would be the majority, but I don't know). For those that don't bother, I assume they'd also want them to be spaced like the rest of their file.

However, I would be fine with accepting a PR for this.

Thanks for being open to a PR.

from obsidian-linter.