Comments (4)
Flattered to be asked. For me, the plant=... is acceptable. to be more agnostic in naming, you could use renderAs
or something like it?
from c4-plantuml.
I am in favor, with one point of concern: I would prefer a different term than plant
. However, I do not have a suggestion yet.1
Other than that, I think you are correct that we should provide the "customer" (user of the lib) with what they want. I think the ENABLE_*
flag is a fair compromise.2
Footnotes
-
I would suggest
shape
but that is already used for a different purpose in the code.element
might work but is also rather ambiguous (as arefigure
,form
,format
andmodel
). AndelementShape
seems a bit too verbose... ↩ -
All of this is, obviously, under the constraint that things are sufficiently documented, but I have no concerns there based on the excellence of your previous work. ↩
from c4-plantuml.
I don't like plant too, but I didn't want to use 'planetUML....' we have basically no UML context.
I could call it baseShape?
I know, the better solution would be if we combine $shape, but
a) $shape is part of tags (atm we have ComponentDb() and this means "database" is part of the "Component()" definition without any tags)
b) and if would combine $shape with $plant and make it as part of the "Component(...,$shape)" then the internal logic==filesize/performance would be increased independent whether the feature is enabled or not
@Potherca: what do you think? (should I combine it and add it to the elements)
from c4-plantuml.
I wouldn't bother combining $shape
, either renderAs
or baseShape
sound like good alternatives to me. 👍
from c4-plantuml.
Related Issues (20)
- Tags and sprites conflict in Rel (update: sprites have white background, should be transparent) HOT 4
- Image gets cut on the side HOT 1
- Adjust thickness of element border HOT 6
- C4_Dynamic no longer numbers all relationships HOT 6
- error a001 on all diagrams HOT 2
- Odd Legend Rendering for Sequence Diagrams HOT 5
- Question: How do I split functions over multiple lines? HOT 1
- Wrong rendering for Rel_R HOT 4
- AddNodeTag in C4_Deployment throws an error HOT 5
- Line styling not recognized when using ELK HOT 2
- "Cannot open URL" on Online Server HOT 2
- Legend text includes unexpected properties (e.g. $lineStyle) HOT 3
- Wrong layout: "== Base Query" <<boundary>> as Base Query HOT 3
- C4_Container diagram not rendering properly HOT 3
- Java OutOfMemoryError with some Sequence diagrams HOT 6
- $baseShape="label" does not use the correct color (size, ...?) in combination with themes
- Descriptions for boundaries HOT 8
- Separating model and view HOT 5
- Single column properties or header lead to rendering error HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from c4-plantuml.