Giter Club home page Giter Club logo

Comments (4)

jlesueur avatar jlesueur commented on June 7, 2024 1

Flattered to be asked. For me, the plant=... is acceptable. to be more agnostic in naming, you could use renderAs or something like it?

from c4-plantuml.

Potherca avatar Potherca commented on June 7, 2024

I am in favor, with one point of concern: I would prefer a different term than plant. However, I do not have a suggestion yet.1

Other than that, I think you are correct that we should provide the "customer" (user of the lib) with what they want. I think the ENABLE_* flag is a fair compromise.2

Footnotes

  1. I would suggest shape but that is already used for a different purpose in the code. element might work but is also rather ambiguous (as are figure, form, format and model). And elementShape seems a bit too verbose...

  2. All of this is, obviously, under the constraint that things are sufficiently documented, but I have no concerns there based on the excellence of your previous work.

from c4-plantuml.

kirchsth avatar kirchsth commented on June 7, 2024

I don't like plant too, but I didn't want to use 'planetUML....' we have basically no UML context.
I could call it baseShape?

I know, the better solution would be if we combine $shape, but
a) $shape is part of tags (atm we have ComponentDb() and this means "database" is part of the "Component()" definition without any tags)
b) and if would combine $shape with $plant and make it as part of the "Component(...,$shape)" then the internal logic==filesize/performance would be increased independent whether the feature is enabled or not

@Potherca: what do you think? (should I combine it and add it to the elements)

from c4-plantuml.

Potherca avatar Potherca commented on June 7, 2024

I wouldn't bother combining $shape, either renderAs or baseShape sound like good alternatives to me. 👍

from c4-plantuml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.