Would TxId be better if it inherits HashDigest<SHA256>? about libplanet HOT 7 CLOSED

I call dibs on this issue

from libplanet.

I think considering TxId as HashDigest<SHA256> makes sense. but it also means that we allow to assign TxId to any HashDigest<SHA256> fields (e.g. Block.Hash). it can be quite fragile.

So, I suggest to make some other concrete type for these type like BlockHash to distinguish among them if we want to use inheritance.

from libplanet.

Having a distinct type for each BlockHash and TxId and they inheriting HashDigest<SHA256> seems good.

from libplanet.

HashDigest<T> was a struct not class so inheritance is not possible. what do?

from libplanet.

@qria You're right. The idea in itself seems invalid.

from libplanet.

I no longer am working on this until there's a new idea for this.

from libplanet.

I'll close this issue until we have a new idea to address this issue.

from libplanet.