Comments (7)
Also, it was unexpected for me that the email editor is working differently from the one at the Workflow > Emails, where the variables are displayed in plain text and the icon to insert variables is different:
Assuming it's a work in progress.
from pkp-lib.
@jonasraoni, is at an old template that should be replaced during upgrade?
from pkp-lib.
Apart from it, reviewAssignmentUrl isn't exposed deliberately:
from pkp-lib.
Also, it was unexpected for me that the email editor is working differently from the one at the Workflow > Emails, where the variables are displayed in plain text and the icon to insert variables is different
I recall variables are replaced before being sent
from pkp-lib.
The new wording for the template is different: https://github.com/pkp/ojs/blob/main/locale/en/emails.po#L251
I assume, the old template had custom modifications and that's why it was preserved, right?
from pkp-lib.
@Vitaliy-1 this is a mix of UI and backend issue.
The UI of the email editor is different, the email editor that appears when I click on the button Submission > Workflow > Review > Send Reminder
has:
+
button, which allows me to select variables, but only theURL
is available (it refers to the{$passwordResetUrl}
.- Only 1 variable
- The variable is not displayed as text, but as a kind of icon, which looks nice for me, see:
On another hand, if I access the email editor of the template, at Workflow > Emails > Add and edit templates
, then it has:
+ Insert content
button- 32 variables
- The variables as displayed in plain-text, which I think is worse (the user might change something by accident)
from pkp-lib.
But I also had another issue in this part, I tagged you here:
https://github.com/pkp/pkp-lib/pull/9151/files#r1636973735
I think it might need some extra review, so I just fixed locally by replacing the variable passwordResetUrl
by lostPasswordUrl
on the template.
from pkp-lib.
Related Issues (20)
- Correct possible dropping of notnull from locale columns on upgrade HOT 3
- Duplicated entry on the list of OAI identifiers HOT 1
- Error Database Duplicate Entry HOT 2
- Pressing "Enter" key does not activate "Save" button in some places
- OJS 3.4.0-5 PHP 8.3 site structure, scripts and css lost behind a reverse proxy HOT 1
- [OJS 3.3.0.13] Cannot updated reviewed file, AJAX error HOT 3
- Upgrade Citations plugin to target 3.5 main branch HOT 1
- Error on Submission Deletion Due to Missing Notification Class
- Add queue job unit tests for 3.5
- Add FieldPassword Vue component HOT 9
- csrf token for API calls without user session HOT 5
- check for egrep in convertApacheAccessLogFile fails although file is present at location HOT 4
- Move ORCID connect button to user Identity tab
- DOI XML export errors are discarded at the API level
- Recaptcha and ORCID button on user registration form prevent form submission
- Deleting authenticated ORCIDs should revoke tokens
- Implement ORCID brand guidelines in ORCID functionality
- Use preg_grep instead of egrep in ConvertApacheAccessLogFile
- Fix ConvertApacheAccessLogFile CLI tool HOT 1
- Add support for public commenting on posted/published content
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pkp-lib.