Giter Club home page Giter Club logo

Comments (7)

jonasraoni avatar jonasraoni commented on August 16, 2024

Also, it was unexpected for me that the email editor is working differently from the one at the Workflow > Emails, where the variables are displayed in plain text and the icon to insert variables is different:
image

Assuming it's a work in progress.

from pkp-lib.

Vitaliy-1 avatar Vitaliy-1 commented on August 16, 2024

@jonasraoni, is at an old template that should be replaced during upgrade?

from pkp-lib.

Vitaliy-1 avatar Vitaliy-1 commented on August 16, 2024

Apart from it, reviewAssignmentUrl isn't exposed deliberately:

// Don't expose the reviewer's one-click access URL to editors

from pkp-lib.

Vitaliy-1 avatar Vitaliy-1 commented on August 16, 2024

Also, it was unexpected for me that the email editor is working differently from the one at the Workflow > Emails, where the variables are displayed in plain text and the icon to insert variables is different

I recall variables are replaced before being sent

from pkp-lib.

Vitaliy-1 avatar Vitaliy-1 commented on August 16, 2024

The new wording for the template is different: https://github.com/pkp/ojs/blob/main/locale/en/emails.po#L251
I assume, the old template had custom modifications and that's why it was preserved, right?

from pkp-lib.

jonasraoni avatar jonasraoni commented on August 16, 2024

@Vitaliy-1 this is a mix of UI and backend issue.

The UI of the email editor is different, the email editor that appears when I click on the button Submission > Workflow > Review > Send Reminder has:

  • + button, which allows me to select variables, but only the URL is available (it refers to the {$passwordResetUrl}.
  • Only 1 variable
  • The variable is not displayed as text, but as a kind of icon, which looks nice for me, see:
    image

On another hand, if I access the email editor of the template, at Workflow > Emails > Add and edit templates, then it has:

  • + Insert content button
  • 32 variables
  • The variables as displayed in plain-text, which I think is worse (the user might change something by accident)

from pkp-lib.

jonasraoni avatar jonasraoni commented on August 16, 2024

But I also had another issue in this part, I tagged you here:
https://github.com/pkp/pkp-lib/pull/9151/files#r1636973735

I think it might need some extra review, so I just fixed locally by replacing the variable passwordResetUrl by lostPasswordUrl on the template.

from pkp-lib.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.