Giter Club home page Giter Club logo

Comments (3)

judgej avatar judgej commented on July 29, 2024 1

Ah, right, I didn't spot that - just saw it in the header template. Those pages that do have titles use the h1 element. Those pages that don't (e.g. archives, current issue) at least don't use it wrapped around the page title.

I'll explore a little more and do a PR if I'm able to add any missing h1s :-)

from bootstrap3.

judgej avatar judgej commented on July 29, 2024

Some examples here:

http://www.maxability.co.in/2014/08/heading-structure-accessibility/

Some great SO answers here:

http://webmasters.stackexchange.com/questions/4515/h1-vs-h2-vs-other-for-website-title-logo-and-seo

from bootstrap3.

NateWr avatar NateWr commented on July 29, 2024

Hi @judgej, the site name should only be wrapped in an <h1> tag on the homepage. That's what the $requestedOp check is doing in this code:

https://github.com/NateWr/bootstrap3/blob/master/templates/frontend/components/header.tpl#L115-L119

Other pages should assign the <h1> tag correctly, as it's done in these for example:

https://github.com/NateWr/bootstrap3/blob/master/templates/frontend/pages/about.tpl#L20
https://github.com/NateWr/bootstrap3/blob/master/templates/frontend/pages/editorialTeam.tpl#L20

However, I notice that some templates don't have a properly assigned <h1>. This is typically when they make use the breadcrumbs component from Bootstrap, which doesn't play well with <h1> styles. I'd definitely be open to a PR that included properly hidden <h1> elements in the breadcrumbs where appropriate, and some basic styles to ensure these fit Bootstrap's breadcrumb component.

from bootstrap3.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.