Comments (3)
Ah, right, I didn't spot that - just saw it in the header template. Those pages that do have titles use the h1 element. Those pages that don't (e.g. archives, current issue) at least don't use it wrapped around the page title.
I'll explore a little more and do a PR if I'm able to add any missing h1s :-)
from bootstrap3.
Some examples here:
http://www.maxability.co.in/2014/08/heading-structure-accessibility/
Some great SO answers here:
http://webmasters.stackexchange.com/questions/4515/h1-vs-h2-vs-other-for-website-title-logo-and-seo
from bootstrap3.
Hi @judgej, the site name should only be wrapped in an <h1>
tag on the homepage. That's what the $requestedOp
check is doing in this code:
https://github.com/NateWr/bootstrap3/blob/master/templates/frontend/components/header.tpl#L115-L119
Other pages should assign the <h1>
tag correctly, as it's done in these for example:
https://github.com/NateWr/bootstrap3/blob/master/templates/frontend/pages/about.tpl#L20
https://github.com/NateWr/bootstrap3/blob/master/templates/frontend/pages/editorialTeam.tpl#L20
However, I notice that some templates don't have a properly assigned <h1>
. This is typically when they make use the breadcrumbs component from Bootstrap, which doesn't play well with <h1>
styles. I'd definitely be open to a PR that included properly hidden <h1>
elements in the breadcrumbs where appropriate, and some basic styles to ensure these fit Bootstrap's breadcrumb component.
from bootstrap3.
Related Issues (20)
- Problem with the display of author's information HOT 2
- User can not provide review interests during registration HOT 4
- keywords: no separator displayed HOT 5
- Problems installing the latest version (3.2.0.3) through the Plugin Gallery in Open Journal Systems (3.3.0-8) HOT 6
- Versioned galley redirects to most recent HOT 3
- catalog category page generates error in 3.3.0.8 HOT 4
- Fatal error on first page using template on system front page HOT 7
- sidebar width too small at medium/tablet sizes HOT 2
- Author affiliation class on details page has a typo HOT 1
- Darkly theme issues on search page HOT 1
- Search throws error when searching HOT 3
- Issue description non showing in issues archive view HOT 1
- Readable theme contains not readable color selection HOT 5
- Bootstrap3 Theme PHP Fatal Error on indexSite.tpl HOT 3
- doi not show in bootstap3 and ojs 3.4 HOT 1
- ReCAPTCHA missing from templates
- Curl issue HOT 1
- The latest release has an invalid version HOT 1
- Missing `Templates::Search::SearchResults::` hooks on search.tpl HOT 3
- Bootstrap 3 EOL
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
should not be the site name
from bootstrap3.