PKHUD.show(onView:) is crashing with iOS 15 about pkhud HOT 22 OPEN

Ok, I thing it'a issue, when you don't pass view. HUD use keyWindow. Changes for iOS 15: https://developer.apple.com/documentation/uikit/uiwindow/1621612-keywindow

It's a fork with commit for this issue: kevin-zqw@597e660

from pkhud.

I don't change library. I only, change my local code:
from:

to:

from pkhud.

I've been experienced this problem since a couple of months ago when the user opens a deep link (the HUD is shown) and the app is not ready yet.
After trying several things I finally tried this, thinking it would be the ultimate solution:

            if UIApplication.shared.keyWindow != nil {
                HUD.show(.progress)
            }

But I'm still receiving crashes in this line (HUD.show(.progress))! Why?? It has no sense to me.
Anyway I'm going to test @MarkerwApk and add onView: view to the call and see what it happens.

from pkhud.

Me too

from pkhud.

Info from Crashlytics

from pkhud.

Do you know the way how to fix those crashes?

from pkhud.

No :( I can't reproduce in debug. I have only reports from users. You pass onView parameter?

from pkhud.

I think it is an answer, I think we should pass view

from pkhud.

Wow, @MarkerwApk when was it fix?

do we have this change in the latest version?

from pkhud.

I thing no. I will try pass UIView and I will be observe Crashlytics.

from pkhud.

@MarkerwApk did you make a pull request to the main repo? Sounds like it's a easy fix

from pkhud.

I am also getting crash on this method when I change the scheme and run the project without running a clean build.
If I clean and build again then it does not crash anymore.

from pkhud.

yes i know how to fix it, however I dont know how to contribute to the improvemnet

this should will fix it

var window = UIApplication.shared.keyWindow //--> nil = crash if #available(iOS 13.0, *) { window = UIApplication.shared.connectedScenes .filter({$0.activationState == .foregroundActive}) .compactMap({$0 as? UIWindowScene}) .first?.windows .filter({$0.isKeyWindow}).first }

from pkhud.

Has anyone managed to fix the problem? I’m experiencing the same issue from iOS 15.4 and 15.5

from pkhud.

Has anyone managed to fix the problem? I’m experiencing the same issue from iOS 15.4 and 15.5

#283 (comment)

from pkhud.

I've been experienced this problem since a couple of months ago when the user opens a deep link (the HUD is shown) and the app is not ready yet. After trying several things I finally tried this, thinking it would be the ultimate solution:

            if UIApplication.shared.keyWindow != nil {
                HUD.show(.progress)
            }

But I'm still receiving crashes in this line (HUD.show(.progress))! Why?? It has no sense to me. Anyway I'm going to test @MarkerwApk and add onView: view to the call and see what it happens.

Look at documentation: https://developer.apple.com/documentation/uikit/uiwindow/1621612-keywindow
It's very bad from Apple side(change behavior and implementation). "onView" should resolve issue.

from pkhud.

Thanks!! I'm gonna try your solution.

from pkhud.

In my case I'm still having issues with the deep linking, I'm pretty sure this is because the view is not ready yet, so I'm trying:

            let isViewVisible = self.viewIfLoaded?.window != nil
            if isViewVisible {
               HUD.show(.progress, onView: self.view)
            }

from pkhud.

Well, I'm still having crashes with this last code...I'll find another option.

from pkhud.

@rferbesa try this
let keyWindow = UIApplication.shared.windows.filter {$0.isKeyWindow}.first

pass the variable to onView and let me know

from pkhud.

Thanks! I'll try that and let you know.

from pkhud.

It didn't work. I think is a problem of how my app detects if it's in background or not (or if the view is being shown or not). I won't show the spinner in the deep linking flow to "fix" this.

from pkhud.