Episode and Season numbering about python-plexapi HOT 6 CLOSED

Expect a pull request for this added functionality in the next few hours. Working on it now.

from python-plexapi.

The major problem with implementing this is the modular way that the XML parsing is done. When an item is built it doesn't have any context of where it was in the XML that came from Plex.

To pass this info down to the Season/Episode objects will require passing down an 'index' parameter into the object.

OR

after an item has been built, if it is part of a list it's index can be added to the item as an 'index' attribute, which could then be read. The downside to this is that the object is already created, and the listItems function doesn't know what type of object it is. It's a bit ugly to put in a 'if type == season' conditional in the listItems function, but it's also very ugly to persist 'index' as a parameter way down to the leaf object constructors.

from python-plexapi.

I've been thinking about this problem a bit as well. The Season objects used to include index and parentTitle attributes, but seems to have been removed sometime in the last few months. not sure about the best way to solve it.

The problem with knowing where you came from is not ideal either because you may not always go through a Season object through it's Show (you can go directly there if you wanted). Maybe we do a combination of both. Pass in the index if we have it, make a second request to the Show (from the Season) if we request index and do not have it yet?

from python-plexapi.

I'm currently testing a solution that uses a little bit of both.

I'm adding an 'index' attribute to 'elem' when looping through listItems. Then retrieving that attribute from 'data' in the Season and Episode '_loadData' functions. The only thing I haven't tested is your suggestion, getting all episodes from a Show, instead of from Season. This uses allLeaves, so it will probably lose the index. I like your suggestion of a combination of both. I'll experiment with it and see what I can do.

from python-plexapi.

Pull Request #55 should solve this issue. Only added 5 lines I think. Was pretty easy to add and I think it's a fairly elegant solution.

from python-plexapi.

commit 36b5d12
Author: Michael Shepanski [email protected]
Date: Thu May 19 23:42:06 2016 -0400
Add back missing index value from Show,Season,Episode; Make season numbers a bit easier to fetch

from python-plexapi.