Giter Club home page Giter Club logo

Comments (6)

GoodBoyDigital avatar GoodBoyDigital commented on April 28, 2024

heya! just to clarify, is this not working but meant to? Or is it that some older formats are no longer supported?
Thanks!

from pixijs.

ddenisyuk avatar ddenisyuk commented on April 28, 2024

Since I'm not aware of your plans for changes in version 8, I cannot be certain, but I expect it should work.

So I did few more tests, and here are my findings:

  1. Compressed textures are being rendered, but it requires manual registration:
    PIXI.extensions.add(PIXI.loadDDS, PIXI.loadKTX, PIXI.detectCompressed, PIXI.resolveCompressedTextureUrl);
    See jsfiddles: v7.4.0 vs v8.0.0-rc.10
  2. DDS DX10 works like a charm in v7, but not in v8 (because new implementation of parseDDS.ts, it looks not so hard to port support from v7):
Error: Unsupported texture format: DX10 undefined
    at Loader.ts:209:27
  1. KTX works well in version 8, but, for me, using a worker to extract raw bytes from the container seems like unnecessary overhead, especially since these are GPU-ready textures that do not require any transcoding. I would rather keep parseKTX.ts from version 7 for KTX and use a worker for KTX2. What do you think?

P.S.: For some reason v8.0.0-rc.10 example render black square in Safari v17.2, while v7.4.0 is ok, in the same time both tests on my local machine are ok.

from pixijs.

GoodBoyDigital avatar GoodBoyDigital commented on April 28, 2024

Thanks for your feedback. Compressed textures are not included by default, they can be included as a bundle. doing one of the following imports will add all the necessary extensions:

import 'pixi.js/dds' // adds and installs dds
import 'pixi.js/ktx' // adds and installs ktx
import 'pixi.js/basis' // adds and installs basis

Im cool with your suggestions, my thinking was that compression will play a big part of adoption for using them on the web - so wanted to make sure that was all covered.

Stacked at the mo, would certainly welcome PR's for adding back DDS DX10 and KTX containers! Up for the challenge? :D

from pixijs.

GoodBoyDigital avatar GoodBoyDigital commented on April 28, 2024

@Zyie what would be the way to install the compressed texture bits when working with the bundle?

from pixijs.

Zyie avatar Zyie commented on April 28, 2024

@Zyie what would be the way to install the compressed texture bits when working with the bundle?

I think this is a bug. The compression extensions should be automatically added when using the pre bundled version of the library. It seems that the code for everything is there, but the extensions.add calls are missing, will need to investigate

from pixijs.

ddenisyuk avatar ddenisyuk commented on April 28, 2024

Thanks for your feedback. Compressed textures are not included by default, they can be included as a bundle. doing one of the following imports will add all the necessary extensions:

import 'pixi.js/dds' // adds and installs dds
import 'pixi.js/ktx' // adds and installs ktx
import 'pixi.js/basis' // adds and installs basis

Im cool with your suggestions, my thinking was that compression will play a big part of adoption for using them on the web - so wanted to make sure that was all covered.

Stacked at the mo, would certainly welcome PR's for adding back DDS DX10 and KTX containers! Up for the challenge? :D

DDS DX10 - #10241
KTX - #10246

from pixijs.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.