Giter Club home page Giter Club logo

Comments (3)

pixelmund avatar pixelmund commented on June 4, 2024

This is now supported in v1.2.0 !

I've looked through the next-iron-session repository to see how they handle secret rotation and liked the approach.
You can find more clear instructions to setup password rotation in the README

from svelte-kit-cookie-session.

rmunn avatar rmunn commented on June 4, 2024

Looks really good, thanks! Having a list is more flexible than the previousSecret I had suggested, since it would allow things like rotating secrets every day while keeping a 7-day expiration. (Which is more paranoid than my use case needs, but some people might need that).

The only thing I'd change about the implementation is that if a session cookie shows up with an ID not in the list, I'd prefer for the session to be destroyed rather than an error thrown. Because the most likely scenario where a cookie shows up with an invalid secret ID is when a secret was rotated out before that session expired, maybe because the secret was leaked (:scream: indeed). I'd much rather have that be treated the same as a session that timed out, rather than have to catch an exception and then figure out what happened to throw that exception.

Apart from that one quibble, thanks for a speedy implementation!

from svelte-kit-cookie-session.

pixelmund avatar pixelmund commented on June 4, 2024

That's a good point i haven't thought of. Thanks for your request! I will try to get it in shortly.

from svelte-kit-cookie-session.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.