Making PittAPI into a proper package about pittapi HOT 4 CLOSED

+1 and congrats on your acceptance!

from pittapi.

@azharichenko The reason for the modularity is that I had plans to store a session in the objects. You might notice that in some cases, such as the Laundry API, we need to get a cookie. Right now I get the same cookie for every call, wasting an expensive I/O call. The plan was to just store the cookie for a period of time in an object, so I kept every class uniform.

However, I like this change. We can look into storing a session for the LaundryAPI later because the overall benefit we get from this is greater than the potential for what I had in mind. Please go ahead with the PR, and congrats to your acceptance to Pitt 😄

from pittapi.

@RitwikGupta Yeah I think we can work out a way with storing a session for LaundryAPI, I'll probably look into that later. I'm right now putting my attention on the CourseAPI since issue #22 brought up some interesting cases that need to be dealt with, plus I think I made more efficient ways of getting the courses but I'm still testing.

Anyways here comes the PR. 🎉

from pittapi.

Closed with 759390f

from pittapi.