Enforce Unicode for all strings and results about pittapi HOT 14 CLOSED

I only see you using \u once, replacing \u0026 with &
I did a replacement once too, of \u2013 to -
I personally think it's easier to work with & and - as ascii characters.

I convert between é and e when I'm translating dining location names to dict keys and vice versa, but I feel like that's more convenient since you don't really want to have to type special unicode characters into a dict key.

from pittapi.

Right, I'm using Unicode characters once in a while myself, but what I mean is for you to ensure that all strings are being handled as UTF-8 in the code. Right now they're mostly being handled as ASCII and that's wrong.

from pittapi.

Encode every string as UTF-8 from start to end

from pittapi.

I see.
So then the string replacements (like \u2013 to &) can still stay but we treat all strings as unicode?

from pittapi.

Once you change all string to proper unicode, the \u2013 will actually go away and we'd be able to use the proper en dash character to replace instead.

from pittapi.

You wouldn't have to do anything with the e either then. It'll properly be represented with an accent automatically.

from pittapi.

I see.
But wouldn't it be difficult to type it in when one is trying to get_dining_location_by_name()?

from pittapi.

Yes, but that function may not be the best idea in the first place especially because it's easier to get all the data anyways.

from pittapi.

Oh okay.
So it's fine to have unicode characters in dict keys?

from pittapi.

Since the main purpose of any of these return values is mainly for display anyways, yep!

from pittapi.

I'll wait until the PeopleAPI asynchronization is finished before doing this.

from pittapi.

Just start working on it in a branch and we can deal with merge conflicts!

from pittapi.

Oh okay got it.

from pittapi.

Dropped Py2.7 support, everything is Unicode now.

from pittapi.