pirey0 / minetest_presentations Goto Github PK

When i'm trying to use the remote i get "greeted" with those errors:

2021-02-18 14:20:03: ERROR[Main]: Invalid label element(3): '1,0.5; ID: 1;'
2021-02-18 14:20:03: ERROR[Main]: Invalid button element(5): '5,0.25; 1.5,.5;Destroy;Destroy;'
2021-02-18 14:20:03: ERROR[Main]: Invalid button element(5): '6.5,0.25; 2.5,.5;DestroyAndCleanup;Destroy And Cleanup;'
2021-02-18 14:20:03: ERROR[Main]: Invalid label element(3): '1,1.25; Move;'
2021-02-18 14:20:03: ERROR[Main]: Invalid button element(5): '1,1.5; 1,0.5;MoveRight;X+;'
2021-02-18 14:20:03: ERROR[Main]: Invalid button element(5): '2,1.5; 1,0.5;MoveUp;Y+;'

Seems that the release from the Online Content discovery only contains luasocket for linux. On Windows, I get this error:

ModError: Failed to load and run script from C:\Users\<user>\Downloads\minetest-5.5.1-win64\minetest-5.5.1-win64\bin\..\mods\minetest_presentations\init.lua:
error loading module 'socket.core' from file 'C:\Users\<user>\Downloads\minetest-5.5.1-win64\minetest-5.5.1-win64\bin\..\mods\minetest_presentations/external/socket\core.so':
	%1 is not a valid Win32 application.

The current setup is not visible in the menu (4:3/16:9, size, ...). If I want to mimic another display I did not build, it takes a lot of figuring out what its the settings are. It would be much easier if they were displayed or highlighted.

Add a button next to "Destroy" labelled something like "Destroy and delete" that deletes all image files on the server associated with this presentation, so unused slides do not pile up.

Feature Add video player https://github.com/mpv-player/mpv

I accidentally hit a moose from the mod animalworld with the remote, and the server crashed.

Please tell me if you need more infos!

Hi, please see https://content.minetest.net/threads/526/#reply-11789

Add peristant data to store downloaded file paths and similar.
Load max_download_length from it
using StorageRef might be a solution

The current presentation spawn behaviour is not in line with the general Minetest UX: although it is expected to spawn a decoration-like element in the world, it is spawned by left- (like a weapon) instead of right-clicking (like placing something), and it does not spawn at the clicked location, but at the player location.

Feature request: make the display a block that can be placed with the usual block placement targeting.

Upon placing, the block could immediately be removed, and replaced by the actual presentation object, which would now be located where the player clicked.

The mod should prevent overly stupid things, such as:

• attempting to download something that does not end in png|PNG or jpg|JPG|jpeg
• attempting to download unreasonably large files

For the second, it could do a HTTP HEAD request before GET and check the content-length: header.

This would also conveniently yield the content-type: header, which could be checked for a supported MIME type such as image/png, providing another safety measure apart from the filename extension.

Requesting the ability to have slides change automatically (without click) at a specified interval.

Hi
First of all , congrats on a great mod, its refreshing to load an image in MT without loss of quality.

I was trying to add new textures ( images ) in the mods/minetest_presentations/textures folder while the server was running.
I then went to the display using the remote in a creative minetest vanila locally hosted server on windows 11.
When typing in the exact filename of the texture, the screen turns pink and an error says:
"Could not load image xxx.png , while building texture, creating dummy image"
If i restart the server, the texture loads just fine.

does the init.lua needs some kind of re-load media call ? i think i saw somewhere that textures can be added dynamically at runtime.

In creative mode, the item should stay in the inventory (or be recreated) after a display has been spawned. Otherwise, one always manually has to put it there again.

When the menu option "Destroy" is clicked, the presentation is destroyed and dropped in the background, but that might not be visible in smaller windows, as the menu may obscure a large part of the screen.

Feature request: close the menu after "Destroy".

When given a https:// URL, the code apparently silently does a HTTP request for the resource instead. This should not happen, at least not silently, as http://re.sou/rce and https://re.sou/rce may point to wildly different things, by the nature of the protocols.

Also, if the server is configured to do HTTPS redirects, e.g. answering a http://re.sou/rce request with a 301 redirect to https://re.sou/rce , the download fails as well, as anything not equal 200 OK is currently considered an error.

In my case I could only solve this by temporarly disabling HTTP -> HTTPS redirects on my server, and serve unencrypted HTTP instead.

HTTPS should be supported natively, and as long as this is not possible, https:// URLs should be verbosely rejected.