Giter Club home page Giter Club logo

Comments (4)

vunguyenhung avatar vunguyenhung commented on May 31, 2024 3

Hi everyone, all test cases are passed! Ready for release!

Test report
https://vunguyenhung.notion.site/Components-google-ads-317d8bc7bf1146f187481a77b05877ab

from pipedream.

vunguyenhung avatar vunguyenhung commented on May 31, 2024 1

Hello everyone, I have tested this PR and there're some test cases failed or needed improvement.

Please check the test report below for more information
https://vunguyenhung.notion.site/Components-google-ads-317d8bc7bf1146f187481a77b05877ab

from pipedream.

malexanderlim avatar malexanderlim commented on May 31, 2024

You will need to refactor the app code for Google Ads, as I removed login-customer-id as a custom field, as this can be an async options call instead and easier to work with than manually inputting the Login Customer ID.

We should have two props if we want to be able to support API operations operating as:

  1. MCC (Managed Account, or Manager Account) 2) Customer account directly.

Please create two additional props:

      method: "get",
      url: "/v16/customers:listAccessibleCustomers",

from pipedream.

GTFalcao avatar GTFalcao commented on May 31, 2024

Indeed it seems a campaign cannot be created directly under the root manager account, so I made the 'managed account' prop required only for this source. Also fixed the bug that prevented events from being emitted after the initial deploy.

from pipedream.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.