Add GetFingerprint() to SessionDescription about sdp HOT 5 CLOSED

Hey @daonb mind trying at the global level also?

pion/webrtc does that here

It might be nice to add AttributeRecursive? This would be useful for ice as well!

from sdp.

fp,ok:=s.MediaDescriptions[0].Attribute("fingerprint")

from sdp.

fp,ok:=s.MediaDescriptions[0].Attribute("fingerprint")

Thanks!

I've tried using it instead of the regex I have now but I keep getting a !ok. Here's my code

func GetFingerprint(sd *webrtc.SessionDescription) (string, error) {
    s, err := sd.Unmarshal()
    if err != nil {
       return "", fmt.Errorf("Failed to unmarshal sdp: %w", err)
    }

    fp, ok := s.MediaDescriptions[0].Attribute("fingerprint")
    if !ok {
         return "", fmt.Errorf("Failed to get fingerprint from sdp")
    }
    ...

from sdp.

Hey @daonb mind trying at the global level also?
pion/webrtc does that here

It works! Thanks. I've ended up using the global level Attribute as terminal7 has no media.

It might be nice to add AttributeRecursive? This would be useful for ice as well!

I'd be happy to help, but I think we should find a better name as it's not really recursive. How about CollectAttribute?

from sdp.

Closing as 'Not Planned'.

This would be a useful helper, but I think it has some ambiguity that will make it harder to land

• What is the behavior if the attributes differ?
• Should we notify the user if was found at global or media level?
• ?

If someone is passionate about this issue I am here to help though!

from sdp.